From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 138506CD8
 for <dev@dpdk.org>; Tue, 11 Oct 2016 11:41:01 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP; 11 Oct 2016 02:41:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,476,1473145200"; d="scan'208";a="18812731"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.94])
 ([10.237.220.94])
 by orsmga004.jf.intel.com with ESMTP; 11 Oct 2016 02:40:59 -0700
To: Keith Wiles <keith.wiles@intel.com>, dev@dpdk.org
References: <1474423220-10207-1-git-send-email-keith.wiles@intel.com>
 <1475592311-25749-1-git-send-email-keith.wiles@intel.com>
Cc: pmatilai@redhat.com, yuanhan.liu@linux.intel.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <55727b18-484a-311a-46ef-37fa3d4f7dfc@intel.com>
Date: Tue, 11 Oct 2016 10:40:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1475592311-25749-1-git-send-email-keith.wiles@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v4] drivers/net:new PMD using tun/tap host
 interface
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2016 09:41:02 -0000

Hi Keith,

On 10/4/2016 3:45 PM, Keith Wiles wrote:
> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces
> on the local host. The PMD allows for DPDK and the host to
> communicate using a raw device interface on the host and in
> the DPDK application. The device created is a Tap device with
> a L2 packet header.
> 
> v4 - merge with latest driver changes
> v3 - fix includes by removing ifdef for other type besides Linux.
>      Fix the copyright notice in the Makefile
> v2 - merge all of the patches into one patch.
>      Fix a typo on naming the tap device.
>      Update the maintainers list
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  MAINTAINERS                             |   5 +
>  config/common_linuxapp                  |   2 +
>  doc/guides/nics/tap.rst                 |  84 ++++
>  drivers/net/Makefile                    |   1 +
>  drivers/net/tap/Makefile                |  57 +++
>  drivers/net/tap/rte_eth_tap.c           | 866 ++++++++++++++++++++++++++++++++
>  drivers/net/tap/rte_pmd_tap_version.map |   4 +
>  mk/rte.app.mk                           |   1 +
>  8 files changed, 1020 insertions(+)
>  create mode 100644 doc/guides/nics/tap.rst
>  create mode 100644 drivers/net/tap/Makefile
>  create mode 100644 drivers/net/tap/rte_eth_tap.c
>  create mode 100644 drivers/net/tap/rte_pmd_tap_version.map

This patch needs to be rebased on top of latest next-net, .init &
.uninit are no more used.

Also patch gives a set of checkpatch warnings, fyi.

Thanks,
ferruh