From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF920A0C47; Thu, 2 Sep 2021 12:11:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7E7740041; Thu, 2 Sep 2021 12:11:48 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 67BC04003C for <dev@dpdk.org>; Thu, 2 Sep 2021 12:11:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10094"; a="206280014" X-IronPort-AV: E=Sophos;i="5.84,372,1620716400"; d="scan'208";a="206280014" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2021 03:11:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,372,1620716400"; d="scan'208";a="499679515" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 02 Sep 2021 03:11:46 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 2 Sep 2021 03:11:45 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 2 Sep 2021 03:11:45 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 2 Sep 2021 03:11:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kxba60umjSaEn9kGAA65Gx3NmTatyJth7FOZuNN94WJDy7Lw8Rls8sw8dENXgwERgv+vgJcJQFTNKbA80dr1o9V/gb97x/mAOy/6MErx+CXNMBjTe2+iW87rQDdSeau2vRA0pNgp4anM7IXHpclqvKxG1bsE6QlfzNB0VE+el3us1gTZ2X++MzHpFO5W9OqugPzzKIRG9Qm5y7L+teN+/pV4rW4r7rPmKLgsVKHLupwA/y/8S7NtUjeOYfoFnP12S5M+/kh9yoZJZjekkcKS2U71Pg816OtT3eb47YzLYq9BPUAOvOFco+JXpcqV5e0phYObVlQf5Gbq3JD0Yzi9RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rbEpoPLdZc/2LMnrdsWL6NC3bSj3ORvMuJVwlA2RfoU=; b=UEFmO5bgHnmGwX7oLbLuJlof0bwi0Zdo8KVWP5wirvvfEtUDqxePEPswuQ2nU7R5l7hV5nNxalshP8H+bKmungmyZt4JgtYrH5sEDbwN56cI1L/DHoCRM85naSfrTENRongFQPW3e+G5aremOBDq1/kqzlkxg3pFhMSCTn754WXvhYqwGaZB4RO/d4fBTRksnB/i/4LTJG22l9YgpUjmeUgclQtWeTZrLZ5PXz+MR+zlfEKczAOSFepiyCr3fbstieOZPMsLCHwPGSeCkiVKhVmjzTBHTUqPNZ/+qgeFR+dilwAG1L7tJvdKu0jw4DIqEBrDM5kWxb3koX/qcWpfKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rbEpoPLdZc/2LMnrdsWL6NC3bSj3ORvMuJVwlA2RfoU=; b=Ay8lniGvQaooFoQ/CjZork0HcM+Is/zuZW3mXQ4JEh68DDL+NI0MwEmynQSGLiEZWqCTOStUvjLFG6rppxIZNZUGFblxl1Sd1rRk/HN5+WxuiBAQGI/KaxN+mjgbdRhdbZ/5lrOACuMRSqmZWGTVeIa/nnx6Ig8qURWVmahp3ek= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5063.namprd11.prod.outlook.com (2603:10b6:510:3d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 10:11:44 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.020; Thu, 2 Sep 2021 10:11:44 +0000 To: Stephen Hemminger <stephen@networkplumber.org>, Aman Singh <aman.deep.singh@intel.com> CC: <dev@dpdk.org> References: <20210901061821.5259-1-aman.deep.singh@intel.com> <20210901101253.6991a2f6@hermes.local> From: Ferruh Yigit <ferruh.yigit@intel.com> X-User: ferruhy Message-ID: <557a6cce-a043-357e-9f00-ea15025bf43f@intel.com> Date: Thu, 2 Sep 2021 11:11:39 +0100 In-Reply-To: <20210901101253.6991a2f6@hermes.local> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR07CA0075.eurprd07.prod.outlook.com (2603:10a6:6:2b::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0075.eurprd07.prod.outlook.com (2603:10a6:6:2b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Thu, 2 Sep 2021 10:11:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e2bc3fcd-19f7-44fc-6437-08d96dfa10fa X-MS-TrafficTypeDiagnostic: PH0PR11MB5063: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <PH0PR11MB5063C83594F7E7FBAD567BAF95CE9@PH0PR11MB5063.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zk3/lzR4rCLh54wFPoGute4ELh8KH67os4zSvx+/FX+xMow0Rm1wZX23SQAmpydIGvP7EjrVQpm1IHYd5o1KGQsAZ+61hLOWfmWxUxghzUaKowX/rdodhLORxDfFdnJ2BN2oPH4ucD8pjik2Jy4OMDir9MEBVqxc2z7lMIcLK16mXIj0Z9vpB9tiOIZ8qZgm8IdWkTez36HHhsyXfexafzAIDSRmFx1uzbfr7if/z0TdM04m/uOTiTnEB59D43qRqSmQJUt5UucxcLbFZA9oZjF1jxgnqltqgXNjgl0ByqMI3jCyiap3FbczsomLsphAfA7IYlGwMZmuKhwfT+/bU55zuNzPULE1Vw+gd0NhsfUvfwZoMq3NLznDkmnGPdylGtdHzpOt8XtTELATkDD7AJlugv/MVd4cdGUQbchcbvDOZYJXQow5AEB6O7q5SCp0jPT7Fe+yqM6ZO4s7YtDeVUUvWiojDxj9EQAgup3EfbDjHnyvJsskdsxq8tKpWKV5E12AjYrx5PgDa/PkvPnmVHNX/Og8GcmNzvMAVjDoupkYYMp3vFi6G9kOv8VEQWXOgI189SeZxQfcyHUjFBUui6wvjg1nnW+Y1pIDeEyNq+/HFsdg8I9wowkvXVL7EyPTPdaR8HTU16Xvsi0iZAZjcRVvABS5FXFj1ORCg0o1KlDQ5Rd0zvD/hYopT2EnrwnBudFoCv2LqSmmhQ2QM3tFnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(346002)(396003)(376002)(366004)(53546011)(8676002)(186003)(16576012)(36756003)(66556008)(66476007)(26005)(6636002)(38100700002)(4326008)(66946007)(2906002)(478600001)(6486002)(86362001)(2616005)(956004)(5660300002)(83380400001)(31696002)(44832011)(8936002)(31686004)(6666004)(316002)(110136005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bldKYTNRNGxtYnNrMzRHSWNyUFZTVTdDWDQ4UTR2SnFNZGZMcktqSmt3eDZv?= =?utf-8?B?Ymc0MFlBRjdhb0lXSkdEV3ZYcTIvY25wZUVKbEM0VFU4Sm5GSFQ3V1dkVmNV?= =?utf-8?B?MkJrMW9SbVBZM2VNcllZM0IyUnorZFRFQW40ZWkxd0VTbUhLZitQVko3eHlE?= =?utf-8?B?enNqTFdwTlpwYU0xSU9zQW9VUTAyaytpajZsc0VXTGVWN1kzMW1hbmZiTG5I?= =?utf-8?B?Qk1zbmlqL2gzRkVjWml1SldTcmR4NW5LWFRpSE9GT2JwN0xycHZINSs1S0RF?= =?utf-8?B?UVREYWgvZnJRZUxDMTlaaGZxSGlNUnowOWU5eWlQK1IvMGpmUEltZ0cvVGtp?= =?utf-8?B?c2lRZWxEbjVncDMxMmNjczNRZ1FHTjFoU052Ym9GcVZTWDN6Vy9LRGpCekpQ?= =?utf-8?B?dm5iVU5yL3QxK3ZLNmV1WnFJeDczVjNjVlRHTHJPVGhKb1NJMXVkNWhWTHpi?= =?utf-8?B?Vkd5RFU5K3hDMG1KZEpWbGZXc0R4dEFXdDM4T3I2V2srRVRPbFhjWDNZSUJ0?= =?utf-8?B?cE1SWnpmbklmYmhzV0p5aGJTTHFmTzMzbEd3VUcwRHFUZlB5ZzF5NDRRbUxC?= =?utf-8?B?Vk9rR21rTzUyMFdNRGhVWHQvdTFWZkZNSmNBRDFiVEM4OHNwaUxOUk0xN2Jj?= =?utf-8?B?V05IbmRDdk5aMXlCSzRuMHRaNVBvOHE3ajBIMHhNd2lkRmFjekFjZWNheWZ6?= =?utf-8?B?V2VRQTJRRXdYU3VhUDFHaHF3TnlNbDk5MGJmUDFQL3RjRFR0ZnppRUlMc3Vl?= =?utf-8?B?SlpUMkNKOGNUOWhkc1prUkJxT2d5M1hBV1VzZ2tMS3ZqcVRFVng3cnRwWGhL?= =?utf-8?B?SG1MVE9QYm9ZTzliR3R5NHhuUmxXb1BaWThmS0FXL2JUQTZFakJvdkVIaWQ4?= =?utf-8?B?b0l0VG1oMVN6UVI1akVXdUp1eVRHN3RlV21ubnpnd2NHcExMVVRnZTV0LzRN?= =?utf-8?B?dVpEZkE2K3o4MDI1aVRhZGRQQWRuYnZzaWhBU016NExldGozaWtyT2VMQkJy?= =?utf-8?B?NGRSN3hGdFFONW9XdjEzRmd1dW5jZU1COVpXeXdPUHJzdXpVQ2RscWF3Si8v?= =?utf-8?B?U1FJRlBxMkxRRUtFNTNWL2lHTTRyQm1sUURicEpoWDVsN0JyVU91NnVjZEls?= =?utf-8?B?citqbHR5WmxIOWxFTEtybWx6YU5IWVp0NEEwQm43ZlEwSU1uNUxLNUpGTlZ0?= =?utf-8?B?ZHlwOUg0ZGhobm5vaityZGFoa1dtTks3MHlSZHV2Y3d3ZVVYNVdXd2QyMzdL?= =?utf-8?B?NkU5Rzdvd05ITTdzV05FZ0NZZHJqQklzQ1FzTCtXdkdoN1RwcjZGU293L2VJ?= =?utf-8?B?WngxWER1NnI1b3VjNDdlZkJUZXNuOGR6aHExZDM4ajViOXRYUTlRWm1ZWFZB?= =?utf-8?B?bmd4VloybWh1WXloSWJLNkE3V2JBTHV1cjFTT2Nxa3hVRDdOc2NsVUVDbG9V?= =?utf-8?B?aERkZGdkWi9kQkpzZWhNalhESEtDb1FodUVWN29JRDFrYkRycngxZHoySXVj?= =?utf-8?B?UUJkT2dHME5ORlpJK1l2QTBreXJjTTJ5ME9BdDBpU2p2S1g4Tm92eUlSd0NQ?= =?utf-8?B?WkpYcGx4c0plUVdQZzlNVm9tNFBkZEhxR2RUd2RyTjBQcTBYTFFqMWVSUDFp?= =?utf-8?B?OG1KZEdQdmdyOUc3SHJ0NWJ2Z0NtVkNtWlRNWDRHNk02ajFWcWtNSytBSjNV?= =?utf-8?B?LzFFUTlNZE8zRnowRWc5dTlMMk5rSHNoVGJEb3lVNmo0S3dQQStTMmJuNG8z?= =?utf-8?Q?DVFoKIRJ6rVEIJFID+W9fN5xO17ECuFTj4sp/Ul?= X-MS-Exchange-CrossTenant-Network-Message-Id: e2bc3fcd-19f7-44fc-6437-08d96dfa10fa X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 10:11:44.5783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fnlzdRqWrcuYZROh3UY2klem1TCp3/YYQ8fDas6tVTVtWTR1k86Fh+IUTRc2U3unXtcx9Bljl0J/WzjW+qL9bA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5063 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 9/1/2021 6:12 PM, Stephen Hemminger wrote: > On Wed, 1 Sep 2021 11:48:21 +0530 > Aman Singh <aman.deep.singh@intel.com> wrote: > >> From the logs it is difficult to get the DPDK version >> that was used. So added a debug log to print the same. >> The log has been added in eal_init so it gets printed >> at startup for any application. >> >> Signed-off-by: Aman Singh <aman.deep.singh@intel.com> >> --- >> lib/eal/freebsd/eal.c | 2 +- >> lib/eal/linux/eal.c | 2 +- >> lib/eal/windows/eal.c | 1 + >> 3 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c >> index 6cee5ae369..a14a205f4d 100644 >> --- a/lib/eal/freebsd/eal.c >> +++ b/lib/eal/freebsd/eal.c >> @@ -958,7 +958,7 @@ rte_eal_init(int argc, char **argv) >> } >> >> eal_mcfg_complete(); >> - >> + rte_log(RTE_LOG_DEBUG, RTE_LOGTYPE_EAL, "DPDK version: %s\n", rte_version()); >> return fctret; >> } >> >> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c >> index 3577eaeaa4..a50960cc78 100644 >> --- a/lib/eal/linux/eal.c >> +++ b/lib/eal/linux/eal.c >> @@ -1332,7 +1332,7 @@ rte_eal_init(int argc, char **argv) >> } >> >> eal_mcfg_complete(); >> - >> + rte_log(RTE_LOG_DEBUG, RTE_LOGTYPE_EAL, "DPDK version: %s\n", rte_version()); >> return fctret; >> } >> >> diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c >> index 3d8c520412..5e6d5d8930 100644 >> --- a/lib/eal/windows/eal.c >> +++ b/lib/eal/windows/eal.c >> @@ -419,6 +419,7 @@ rte_eal_init(int argc, char **argv) >> */ >> rte_eal_mp_remote_launch(sync_func, NULL, SKIP_MAIN); >> rte_eal_mp_wait_lcore(); >> + rte_log(RTE_LOG_DEBUG, RTE_LOGTYPE_EAL, "DPDK version: %s\n", rte_version()); >> return fctret; >> } >> > > NAK > DPDK is already too chatty at startup. > Is it better if the log is 'debug', so it won't be visible by default? This can be useful to support customers, sometimes when there are multiple binaries around, it is hard to say version of them. As Bruce reminded, '-v' eal option provides this feature, which is better than nothing, but it is not as useful if you are looking to an old log without actual binary. > If your application needs it then do-it-yourself. > Application may have its own versioning, which can be unrelated to the DPDK version numbers, this can be useful to get just DPDK version.