From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id A56142BA3 for ; Fri, 1 Apr 2016 15:44:01 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id p65so26690170wmp.1 for ; Fri, 01 Apr 2016 06:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=kcZnu9brZ6nFtPYqRyC023+CZbhbT4eZAmBMb6U5n7g=; b=onRmsetAfZ84g18W/cpCU6gbHJ6tR+rS5SIhErVCAUVQTal+hvOXEhDtihvsOEk2of ggpZfPteanNtV85POxWNT1D+rcS7R2Y2P+sWOSSdFKY+QHZjbkQY1BB0felLAabgCS0v CWWO/4Nt6gj4iL4kFIsn76bNqRrtN6tcxVuOF0sIWiZpB8Qp/8C4tuauBFkr2IIzw2hB 1pbBp++AFw/3jpz+4CPlXMG65uBwxIQXLU88GeKDyla7EKHHX4qOBxYEDpKmTmc0RGFF qVeQy4Ilc2UMt+sfIQhqObT6f9ypwwvEz7/qNSm/hifTrWoNVxd5ZZIK+YQv5HPl4m8W +n8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=kcZnu9brZ6nFtPYqRyC023+CZbhbT4eZAmBMb6U5n7g=; b=aQRZDoEP0Senq6Ez9ZPyz5amrEjtTNb39TDglnSjOS2HFn1CLHKacK7UrIxjOznqMR fLD80vJ65XiglZnIfIuoJ/kFlecl10vhTEeKAaiGIdb1DTUle3pCcRcCFBMK9c8kJfE5 1UdfwXTOVlzFzvqSr/K7c0pZ79JDsJfBkS0Sm453oPbVPdYsZI01V1cwwLjWhJ5w2y1E xa69Q7ZX5mUsswQj5nKPGRT0TJZbBj8MUeHY7QZk6TkMD0wuVQOah+bcGYPzwJx1xErT /BVyTM4o4kYV4wQEkuTnDZQNVxwoG5F/AQ0O3TUeQdmrA7XZFCqLKHwsE/bTPsvsH11j LMWQ== X-Gm-Message-State: AD7BkJI+2SG4FAwaDH/+b+ajr1KQgJqtSbaH92hNAIKoqbNnrhSO2MOHgu7tfT2dwbjAbR58 X-Received: by 10.194.133.161 with SMTP id pd1mr21520002wjb.96.1459518241491; Fri, 01 Apr 2016 06:44:01 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id cb2sm14164785wjc.16.2016.04.01.06.44.00 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 01 Apr 2016 06:44:00 -0700 (PDT) From: Thomas Monjalon To: Rami Rosen Cc: dev@dpdk.org, helin.zhang@intel.com Date: Fri, 01 Apr 2016 15:42:06 +0200 Message-ID: <5581186.MKO4P7cXSW@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458955928-11536-1-git-send-email-rami.rosen@intel.com> References: <1458955928-11536-1-git-send-email-rami.rosen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] i40e: Remove redundant fdir forward declarations. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 13:44:01 -0000 2016-03-26 04:32, Rami Rosen: > This patch removes several redundant forward declarations > in i40e_fdir.c. I have the feeling that writing some useless forward declarations is common in some drivers. So why removing only these ones? Are they the only one in i40e?