From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9251A0583; Fri, 20 Mar 2020 11:45:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F8DC2BF2; Fri, 20 Mar 2020 11:45:04 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id CBCCE3B5 for ; Fri, 20 Mar 2020 11:45:03 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 4F079580212; Fri, 20 Mar 2020 06:45:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 20 Mar 2020 06:45:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=UYl+lh7EYVP/XEth4QKF/sTtK+n3iePNXgc6cUR5TSU=; b=A1BWtBN1d0/e 0g+y3KglvTXq+9h7d7sKcIqCL0Npl4Xs2taI0NpkdKWK7oegSGQvAXp8PjsnjIRw hPifVB6ykrtsahIAPnUhY4pS9dvM0mZwohA7I6TTXFZ6Wv0qSU2BIILB6b30WjHg sXKN/QoobTX426Al3J5R01K7mHxUlbQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=UYl+lh7EYVP/XEth4QKF/sTtK+n3iePNXgc6cUR5T SU=; b=D4uRXQAov+bfvNGO/tJJyS6Se4CbKuM6UkAm0Tl1XQVtVNG/Hi6IXo7pN OORabAOVSEFrNtZx6aCYX1qwS8MUQ+V6kxZJ6PpfeoQ5ZvuPctW6crGrCBKEu1Es CsbkcPnlaOP+qOxYlGhojDMn64KZlQB97+NaiTmKD7hHFvpg82uNiMUY4hrGastA MUu306d6n0+zvB1YbmQHoT3u/8NGdCKVnrYFroOFJNttOXP08OmDA60XXfUMD89p 8sLU2wCb/kle5uFKyvvdzhTNx71cApskZm015ksSQgzfTe8EiNvZTzBfoPmXokjy 0hRW2hEAxzhz3RRDrkcP5ZKMFAVDQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeguddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9E99F306215A; Fri, 20 Mar 2020 06:45:00 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: "dev@dpdk.org" , "rahul.lakkireddy@chelsio.com" , "Wang, Xiao W" , "xavier.huwei@huawei.com" , "Xing, Beilei" , "Lu, Wenzhuo" , "Yang, Qiming" , "Ananyev, Konstantin" , "Yigit, Ferruh" , "jerinj@marvell.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "maxime.coquelin@redhat.com" , "Ye, Xiaolong" Date: Fri, 20 Mar 2020 11:44:57 +0100 Message-ID: <5581955.lOV4Wx5bFT@xps> In-Reply-To: <039ED4275CED7440929022BC67E70611547E53BE@SHSMSX103.ccr.corp.intel.com> References: <20200311230136.63452-1-thomas@monjalon.net> <039ED4275CED7440929022BC67E70611547E53BE@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/03/2020 06:35, Zhang, Qi Z: > Hi Thomas: > > From: Thomas Monjalon > > > > This series aims to clean-up the big table of ethdev features: > > http://doc.dpdk.org/guides/nics/overview.html#id1 > > > > We could reorganize the information in this table, maybe split it or add/remove > > some rows. > > Before going to such reorganization, we should clean it up. > > > > The first patch is fixing the look & size of the table with recent sphinx. > > > > The second and third patches are removing 8 columns which are clearly > > unneeded: > > - bnx2x_vf > > - bonding > > - kni > > - nfp_vf > > - null > > - ring > > - softnic > > - vdev_netvsc > > > > More columns can be removed by merging PF/VF and vector datapaths. > > If a feature cannot be supported in all cases, it should be marked as partially > > supported (P). > > If a feature is PF-specific (like flow control), that's OK to mark it fully supported > > because it's obviously impossible for VF. > > There are also some features which were probably marked in some columns > > and missed in its VF or vector counterpart. > > Please work to merge and drop these 16 columns: > > - cxgbevf > > - fm10k_vf > > - hns3_vf > > - i40e_vec > > - i40e_vf > > - i40e_vf_vec > > - iavf_vec > > - ice_vec > > - igb_vf > > - ixgbe_vec > > - ixgbe_vf > > - ixgbe_vf_vec > > - octeontx2_vec > > - octeontx2_vf > > - qede_vf > > - virtio_vec > > > > The total gain is to reduce the table size from 71 to 47 columns. > > I agree to remove all the column with "vec", since vector PMD can be regarded as a feature of the a PMD. > But I'm not sure if it is a good idea to merge VF and PF into one column. > From my view, for intel device, VF driver and PF driver just share the code, but they actually are running at two different context. > And likely they will support different feature, merge into one column may confuse our customer if they want to understand what exactly the PMD support. I understand you have 2 different datapaths. My arguments are: - it is the same NIC - you cannot summarize everything in a table - we have two many columns to make it readable I think the right solution is mark features as partially available (P), and give details in the driver guide documentation. Can you please, at least, remove the "vec" columns, as a first step? Thanks