From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9967843B53; Wed, 21 Feb 2024 03:00:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21C09402B9; Wed, 21 Feb 2024 03:00:00 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id EE6F84014F for ; Wed, 21 Feb 2024 02:59:58 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EDA535C009D; Tue, 20 Feb 2024 20:59:56 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 20 Feb 2024 20:59:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708480796; x=1708567196; bh=xyMcwkLU/G13SaW7Iupdm2I7me7afWN+DD5nsE6N1Fs=; b= B9XK9KT7H2Ddr8zOifC7OL2P5w4/iDm1hNX/lrMea0IjuVLZPZrh8umFfKEy8o45 vuzGsAAdg9k+tSO9QGCdXFLNyC6PPFGHi5Fq28LFOJI9KrqFG5kQMdsbqByWPASm gg0LeLprV6ZqcNaNd8/BzH2LlSW43pkZgCqU9v+2A0RBne+8AnyML3jKo9N+0OrZ AJQi5jtLK+dt8mWiZDL4wUPhtMP1w8ghWKh/rZbBBAJ18NU/nrMzRgLYeU+sVYWu MtaetQEOQr1QLf1O/1K0K1o68wiMSRu8+uW0gn0XQIY77i64hceMbGZBSLa9eyx1 7auoE/jCyJ4sdCjgtDczKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708480796; x= 1708567196; bh=xyMcwkLU/G13SaW7Iupdm2I7me7afWN+DD5nsE6N1Fs=; b=d cX0B5k7g+LVnpQiFB6mcWFV7GK2y5ip8kAtJchvCP8ffvB309bCcfDkrNIVkoVHm Z/04XQBy3PrEh7hVj8jNxDQGFZYPduLt/8Goz/VnNfUqKTP2m4iQJ82tCsNwVvMj zld2ReHXWE4nxQ9J0wejcllhMs53TlHKUONsZiKLproY9ft6qWw/zuHhE2e/TUpv wkhlXZcwmpkmSZzJICLqSErA4sz72g886CNI5D1l70nQdMoQmXUF1AQczDGoiCy3 MKwdU5etegXd7mlu0TdSqiZmQB4N13YnEr3CDs7IuYb860pwCya9VUkGdG81s3vP dpfu5HI0/L/5yZlQl/UZw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedugdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Feb 2024 20:59:55 -0500 (EST) From: Thomas Monjalon To: Tomasz Duszynski Cc: dev@dpdk.org, Jakub Palider , jerinj@marvell.com, david.marchand@redhat.com, stephen@networkplumber.org, Jerin Jacob Subject: Re: [PATCH v2] raw/cnxk_bphy: switch to dynamic logging Date: Wed, 21 Feb 2024 02:59:54 +0100 Message-ID: <5588023.3daJWjYHZt@thomas> In-Reply-To: References: <20231114080446.3574237-1-tduszynski@marvell.com> <20231127181151.302124-1-tduszynski@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/12/2023 15:09, Jerin Jacob: > On Mon, Nov 27, 2023 at 11:42=E2=80=AFPM Tomasz Duszynski > wrote: > > > > Dynamically allocated log type is a standard approach among all drivers. > > Switch to it. > > > > Signed-off-by: Tomasz Duszynski > > --- > > v2: > > - cleanup remaining plt_ log calls >=20 > Applied to dpdk-next-net-mrvl/for-main. Thanks Sorry, a patch from Stephen has been merged first in the main tree. The main difference is on log registration: Stephen's patch: RTE_LOG_REGISTER_SUFFIX(cnxk_logtype_bphy, bphy, INFO); Tomasz' patch: RTE_LOG_REGISTER_DEFAULT(bphy_rawdev_logtype, WARNING); RTE_LOG_REGISTER_DEFAULT(bphy_cgx_rawdev_logtype, INFO); There are also many leftovers that were missed in Stephen's patch (plt_err, plt_warn). Please could you send a rebased patch to fix what was merged?