From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f179.google.com (mail-ie0-f179.google.com [209.85.223.179]) by dpdk.org (Postfix) with ESMTP id 57263B0A4 for ; Thu, 26 Jun 2014 18:20:12 +0200 (CEST) Received: by mail-ie0-f179.google.com with SMTP id tr6so3277686ieb.38 for ; Thu, 26 Jun 2014 09:20:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=iHPUQ07wr2wGb5qZZBV3nBGVzY1tjAK1AjpvdFi9Bio=; b=gOxHNQgI+FgTYRmL6Uef94l/fEs926jQ3WL8UTaveR+2k3T/IP4+hGMfD4cEgN8E2H pA8I5DYq8xp+UMfJqYanGKWXxTy16cA53/6uSLYlligILw5yeAeju+u0dAhbrASTID2W Bixyl1exbyLVq/dUGAtrrwC6kWPoPqVs6XN0Ty4zyH5eGVEyIskD8CD/yGp82zM60s4c jz+oMO4uD0vq2VfRAh/6pFXGZyz4qIBaTkwICHFFGna1xzMgp/oMUDmOBLDv8GQGrdC5 AJwZK4Ap2lVzWAGtVc3Bc3Zk1hF2Dy3umzPrgpUGXkfbtBekY+4z+4NLyd+XXGsL5BTr 9ctg== X-Gm-Message-State: ALoCoQnio2H8bqrrbIyCv2JClZqcbsZ6EQjzXNjw2P3Uak2iOTTHQWoCWMfKuazblWPaVIhZi2s4 X-Received: by 10.50.92.33 with SMTP id cj1mr5781800igb.2.1403799630338; Thu, 26 Jun 2014 09:20:30 -0700 (PDT) Received: from [172.31.1.101] (hlfxns0187w-047055111040.dhcp-dynamic.FibreOp.ns.bellaliant.net. [47.55.111.40]) by mx.google.com with ESMTPSA id hv1sm1260937igb.0.2014.06.26.09.20.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Jun 2014 09:20:29 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) From: Aaron Campbell In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEF87D2@IRSMSX103.ger.corp.intel.com> Date: Thu, 26 Jun 2014 13:20:31 -0300 Content-Transfer-Encoding: quoted-printable Message-Id: <5590E373-EC37-4544-A983-52156CFA81E2@arbor.net> References: <20140624090253.140206a7@nehalam.linuxnetplumber.net> <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com> <12214985.ClK2CaJOyY@xps13> <59AF69C657FD0841A61C55336867B5B02CEF87D2@IRSMSX103.ger.corp.intel.com> To: "Richardson, Bruce" X-Mailer: Apple Mail (2.1878.2) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2014 16:20:12 -0000 On Jun 26, 2014, at 12:09 PM, Richardson, Bruce = wrote: >> I agree we should try to use the "deprecated" attribute when = possible. >> So application porting effort will be smoother. >>=20 >> But in this case, there is something different: as Stephen wrote, = rte_snprintf >> is useless. It's useless inside the DPDK so it's even more useless = for user >> applications. >> As it's really useless, it has no sense to keep it as deprecated. >> Please, let's simply remove it. >>=20 >=20 > The reason to keep it as deprecated is so that those customers who = don't want to do a huge amount of search-replace immediately can get = things working again temporarily using -Wno-deprecated. It provides a = simple temporary fallback cushion, and then we can completely remove the = function later.=20 > So, I'd like to see us remove all our usage of the function internally = in 1.7, along with marking as deprecated, and then completely remove in = 1.8, (i.e. in a week's time or so) :-) As a DPDK user, I=92d vote to kill it now. I doubt it is widely used in = any external applications. Such usage would be mostly from copy/pasting = the sample code, is my guess. -Aaron=