From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50F0EA00C5; Thu, 7 May 2020 12:28:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F117E1DBA5; Thu, 7 May 2020 12:28:32 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id ED21A1DBA2 for ; Thu, 7 May 2020 12:28:30 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 7D56E613; Thu, 7 May 2020 06:28:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 07 May 2020 06:28:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= LU0BIrPrYjFf1/EzRnVKGLlaImHLYMCNh2aJNo3kGv4=; b=ROnZDARkF8iI3dJ8 lW4xgsGtiVXsgDgX9JRryvXYijkFAhW/RXqUvDEzogf7Aq4q5eOgVY0iE3eJlST9 jqi/O1r4zaHqQ/zvUe1xHzsTeaTAeX7VVdrLPeEltRjEN/DQZXwFKbezCNDhlSYx 2k3J6H+qciZzeryhAutICiIm/s9NmyRUMWMTaiBH9UsMFPRfw6Qgzwj5mVhsr0iQ fjo2vNCPyyiwayNO2/ZHStzxKJmrv4k1bjf6yg+kh4e+/x2wEopx/rVxMEgRCjBi xjVC/6dcAyLLA2OiMRFu+zJ3Y7jrTmGFlDo5DASm6Mwn6YlBj83EfC4364RGE2EL jnOnZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LU0BIrPrYjFf1/EzRnVKGLlaImHLYMCNh2aJNo3kG v4=; b=vR8lznxG9J9xGWCLGQYqPJERSirm0IwznwT9fci+5zKIodAPVRdUoUDbA rh/P5Y8iFVQT7b2yeqgEqS5vG1SfGqLjBhkBiW/rgP+VJsl+Ya7D86l3oGkhvzI8 QHwlmIY7NTIJ83y6QLj97eKJd6yPfrMNRHFXjah2J6Uxv8XyoD35/WJpnJ05G6Zw phz59hiD/OC3acQLC3kedaAVdAh7a5q9A15OlZ08cDaRqilCg5Hpdrx3NZ8iXKdW WkTSP4/ibJJq0KMOQTyEPb+dC+PlWYEbWMkdXt4dkiYi+i58QsUQHebOVvSfpLPJ 4SBoYM8wQvT1052elgIzs/xWw6vCQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkedtgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BFC76328006C; Thu, 7 May 2020 06:28:27 -0400 (EDT) From: Thomas Monjalon To: i.dyukov@samsung.com, Andrew Rybchenko Cc: dev@dpdk.org, v.kuramshin@samsung.com, david.marchand@redhat.com, ferruh.yigit@intel.com Date: Thu, 07 May 2020 12:28:26 +0200 Message-ID: <5595669.UjTJXf6HLC@thomas> In-Reply-To: <0deb10b5-2ea0-e319-a23d-893b0c625e1f@solarflare.com> References: <4816966.qqrk5fENW1@thomas> <20200427095737.11082-4-i.dyukov@samsung.com> <0deb10b5-2ea0-e319-a23d-893b0c625e1f@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 3/6] ethdev: remove extra 'new line' in output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/05/2020 15:15, Andrew Rybchenko: > On 4/27/20 12:57 PM, Ivan Dyukov wrote: > > Signed-off-by: Ivan Dyukov > > --- > > app/test-pmd/testpmd.c | 2 +- > > app/test/test_pmd_perf.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > > index 99bacddbf..d4df23a93 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -3005,7 +3005,7 @@ check_all_ports_link_status(uint32_t port_mask) > > "Port%d Link Up. speed %u Mbps- %s\n", > > portid, link.link_speed, > > (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? > > - ("full-duplex") : ("half-duplex\n")); > > + ("full-duplex") : ("half-duplex")); > > else > > printf("Port %d Link Down\n", portid); > > continue; > > diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c > > index d61be58bb..352cd4715 100644 > > --- a/app/test/test_pmd_perf.c > > +++ b/app/test/test_pmd_perf.c > > @@ -151,7 +151,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) > > "Port%d Link Up. Speed %u Mbps - %s\n", > > portid, link.link_speed, > > (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? > > - ("full-duplex") : ("half-duplex\n")); > > + ("full-duplex") : ("half-duplex")); > > if (link_mbps == 0) > > link_mbps = link.link_speed; > > } else > > > > > I think Fixes: tag is required here. > > Acked-by: Andrew Rybchenko Yes please, we would like to backport it.