From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2640A0A02; Thu, 25 Mar 2021 15:30:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F2484067B; Thu, 25 Mar 2021 15:30:23 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id BFD5D40147; Thu, 25 Mar 2021 15:30:21 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2903C5C01B2; Thu, 25 Mar 2021 10:30:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 25 Mar 2021 10:30:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= FlM9KGZ/pN1ZOr5ZX6S9xJloefX+q23TsltCxVuR3uc=; b=KLiS9Zo3Z5suRWP8 YWHTDvFlc0ECCRAVdL7+7Pb/DC5D8DEJukJsk/ZAHC/b9PMNNxQ9YKnNZGwruQKY MP3BXTv/Q1peu1R6dgvSBjs4kGSHvwM3P+vwq01VguuyuH52xG2jy+fZNwN2xwLX QBQr6xIns6mUWfTorNdBGuMmUvrFhg7N8BaZIT+Vo9dNz/+chrtPBQ7b/jJfmVQP cQqTzO6VIX/X67KrtbLSzIgR1Lt6ctIL+0OB4dZtYV9AXPn2Kv5eWwZmPAWC5Wef o10rZCITnUmDeOuvhnbWTJQQYacbi6JcSzyWGifkjmz0ZVjjJzxhT+OBiX4lfN8s 2VLk9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=FlM9KGZ/pN1ZOr5ZX6S9xJloefX+q23TsltCxVuR3 uc=; b=m3Pfk6axFjEFEnBp7LLC1CkOdD37bAyCrqH1udzCEbJuinlkUpsdNO6BB hc2xlHE77VZMiE156VbnPMzjA8HcmpeAAcSrXwnOdCOOIlS5iSrlUf7Shli0U27x Jjvf2k85G59cVGbedt/Jtu/kVaWflpEgH6vCIZwi4Y3JKKxtM9ASWkWwsOa5nXlZ BA5zj6QYWDI38yoU214JQx0FBL4qxvFl7DsfJxS7TYiWnPJQJutXVLVe+iX/UO7+ mZeTrNjj5ga3HJNiQ2U98D1ka2xbwT41jwRGgqvUp3BWw3jtkxLG4KMxSLrHeS02 3Hlw77xd9fyA3hptyPGrtIDyq3UHA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehtddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7321F24005C; Thu, 25 Mar 2021 10:30:18 -0400 (EDT) From: Thomas Monjalon To: Yunjian Wang Cc: dev@dpdk.org, david.marchand@redhat.com, anatoly.burakov@intel.com, jerry.lilijun@huawei.com, xudingke@huawei.com, stable@dpdk.org, bruce.richardson@intel.com, john.mcnamara@intel.com, ktraynor@redhat.com Date: Thu, 25 Mar 2021 15:30:16 +0100 Message-ID: <5596810.E6CI0FCbXo@thomas> In-Reply-To: <1607339329-624-1-git-send-email-wangyunjian@huawei.com> References: <1602840525-8848-1-git-send-email-wangyunjian@huawei.com> <1607339329-624-1-git-send-email-wangyunjian@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] eal: fix create user mem map repeatedly when it exists X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/12/2020 12:08, wangyunjian: > From: Yunjian Wang > > Currently, user mem maps will check if the newly mapped area is adjacent > to any existing mapping, but will not check if the mapping is identical > because it assumes that the API will never get called with the same > mapping twice. This will result in duplicate entries in the user mem > maps list. > > Fix it by also checking for duplicate mappings, and skipping them if > they are found. Sorry, that's still difficult to read, and it is not clear what is the impact of the bug. +Cc some english native speakers for help. > Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > Acked-by: Anatoly Burakov