From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 603F45A53 for ; Fri, 17 Jul 2015 00:22:39 +0200 (CEST) Received: by wgav7 with SMTP id v7so3492848wga.2 for ; Thu, 16 Jul 2015 15:22:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=sxwrB3A+m0yT+KCiCCbj3WGL6F8bpQN0lV3Z52M58Mc=; b=S1PTNniViOTz4ReFL+t6uvjupxKMUfFJfrGB1OAEjBEfH+zAQzVbTbg5NLEVakrz8B NUlP5yziO6RkIossaHrgMQqEKl45OMxW3fQrflku4kvGOrawb53SisiJMEfNXlvJEMND C3UXuA45b/G3zwoJYsxPnODXeJ/kAJVhpTCAXb0OhhiQxfBwy2kMCIQ+OWRkg+A1iDOf tCwPrqGswdXfpAXI1YrT/w1807nv+59xiHsstApvBk7a0SG+8Ak0kzwSeei9Lv5UmFmc K1gsuvhOccIg6tRBazfJ1Xl67VjjBdRmvzMGaOap7hrB7K2pWFX3zjUThMsEoYf8Pp8w dnPQ== X-Gm-Message-State: ALoCoQnAKJT0mXtXHA0iSzqtF7kT8AN1tPTMxpJc6BXDAvyDHopmpTiN1Li1nFFzAqjEuI49iEmM X-Received: by 10.194.200.73 with SMTP id jq9mr22790300wjc.52.1437085357936; Thu, 16 Jul 2015 15:22:37 -0700 (PDT) Received: from [10.0.0.4] (bzq-109-64-112-195.red.bezeqint.net. [109.64.112.195]) by smtp.googlemail.com with ESMTPSA id pg9sm15224823wjb.40.2015.07.16.15.22.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 15:22:37 -0700 (PDT) Message-ID: <55A82EAC.5050807@cloudius-systems.com> Date: Fri, 17 Jul 2015 01:22:36 +0300 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: John McNamara , dev@dpdk.org References: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com> In-Reply-To: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 22:22:39 -0000 On 07/13/15 13:26, John McNamara wrote: > Fix for ABI breakage introduced in LRO addition. Moves > lro bitfield to the end of the struct/member. > > Fixes: 8eecb3295aed (ixgbe: add LRO support) > > Signed-off-by: John McNamara > --- > lib/librte_ether/rte_ethdev.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 79bde89..1c3ace1 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1578,9 +1578,9 @@ struct rte_eth_dev_data { > uint8_t port_id; /**< Device [external] port identifier. */ > uint8_t promiscuous : 1, /**< RX promiscuous mode ON(1) / OFF(0). */ > scattered_rx : 1, /**< RX of scattered packets is ON(1) / OFF(0) */ > - lro : 1, /**< RX LRO is ON(1) / OFF(0) */ > all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */ > - dev_started : 1; /**< Device state: STARTED(1) / STOPPED(0). */ > + dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */ > + lro : 1; /**< RX LRO is ON(1) / OFF(0) */ Acked-by: Vlad Zolotarov > }; > > /**