From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 0076B8D9B for ; Wed, 19 Aug 2015 15:44:46 +0200 (CEST) Received: by wicja10 with SMTP id ja10so8888118wic.1 for ; Wed, 19 Aug 2015 06:44:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=+9gEKgPSri4MjJQqjwzIhocAeIgVzZC4xMcEbZNnteY=; b=Q0oGNBqIQQULNe9HbkhXE7T+dWoCPkutz3gHzULTvjU3MLVm7dahAsa6UzkxrF7mEc jCGKmRWrzwQhcPqeL1wtiY1UX1HUMonKWz/depL0hRH70PRz1lBUh69SSbK9GOvL2xMD ZPtybuZt1B23oktP/eU5kQsFDcpVy/hnSIb1/0dVhuIFsmqeXKaO3Io1calBJ6gD9r4l 8HEuteR70Hzb32suCTGS77nYm0abDpNaF8V2zNtNy+m8+ih0PMLcNd84y2Yk6KOdTbZB Oc561Uv0dGAR2UTBxzpYhlzqVdmKtflRQa0eXdt+GTQlMmWSG3fpxEbbcBX5jAn76BDi SgGw== X-Gm-Message-State: ALoCoQlBHfWrZTpCH4F+Fqznn9XkCcs4UymoEtfDt5c1Y2d0q3U0GOnTQvwLqYtKENXK4M2oGGvT X-Received: by 10.180.79.132 with SMTP id j4mr3203514wix.87.1439991886641; Wed, 19 Aug 2015 06:44:46 -0700 (PDT) Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id ir5sm1137529wjb.23.2015.08.19.06.44.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Aug 2015 06:44:45 -0700 (PDT) Message-ID: <55D48840.6070403@6wind.com> Date: Wed, 19 Aug 2015 15:44:32 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "Tahhan, Maryam" , "dev@dpdk.org" References: <1436965894-130019-1-git-send-email-maryam.tahhan@intel.com> <1436965894-130019-5-git-send-email-maryam.tahhan@intel.com> <55D1F57A.8090408@6wind.com> <1A27633A6DA49C4A92FCD5D4312DBF536A4E5720@IRSMSX109.ger.corp.intel.com> In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536A4E5720@IRSMSX109.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in stats structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2015 13:44:47 -0000 Hi Maryam, On 08/19/2015 02:53 PM, Tahhan, Maryam wrote: >> From: Olivier MATZ [mailto:olivier.matz@6wind.com] >> Sent: Monday, August 17, 2015 3:54 PM >> To: Tahhan, Maryam; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in >> stats structs >> >> Hi Maryam, >> >> On 07/15/2015 03:11 PM, Maryam Tahhan wrote: >>> Remove non generic stats in rte_stats_strings and mark the relevant >>> fields in struct rte_eth_stats as deprecated. >>> >> >> Looking again at this patch, I'm wondering if "imissed" should be kept instead >> of beeing deprecated. I think it could be useful to differentiate ierrors from >> imissed, and it's not a hw-specific statistic. What do you think? >> >> One more comment: it seems these fields are marked as deprecated but they >> are still used on other drivers (e1000, i40e, ...). >> >> Regards, >> Olivier >> > > > Hi Olivier > I can remove the deprecated status for imissed to leave the differentiation between errors and missed packets. > igb and i40e will be updated soon to reflect this. I marked them as deprecated to deter their use in the future. Older instances/use will need to be resolved. From my point of view, yes, I think it's better to keep different stats for imissed and ierrors as it can be useful to determinine the cause of packet losses. If nobody disagrees, I think we could remove the deprecation notice for imissed. Regards, Olivier