From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DD6F6E5D for ; Thu, 14 Sep 2017 18:25:33 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 14 Sep 2017 09:25:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,393,1500966000"; d="scan'208";a="151886342" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by fmsmga006.fm.intel.com with ESMTP; 14 Sep 2017 09:25:31 -0700 To: "Kumar, Ravi1" , "dev@dpdk.org" Cc: Thomas Monjalon References: <1505324838-25734-1-git-send-email-ravi1.kumar@amd.com> From: Ferruh Yigit Message-ID: <55a21367-8a63-a5e3-5260-2069bc2095c6@intel.com> Date: Thu, 14 Sep 2017 17:25:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/4] Add AMD XGBE Ethernet config support in DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 16:25:34 -0000 On 9/14/2017 10:48 AM, Kumar, Ravi1 wrote: >> On 9/13/2017 6:47 PM, Ravi Kumar wrote: >>> Signed-off-by: Ravi Kumar >>> --- >>> config/common_base | 6 ++++++ >>> mk/rte.app.mk | 1 + >>> 2 files changed, 7 insertions(+) >>> >>> diff --git a/config/common_base b/config/common_base index >>> 5e97a08..fab46b5 100644 >>> --- a/config/common_base >>> +++ b/config/common_base >>> @@ -405,6 +405,12 @@ CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y >>> CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n >>> >>> # >>> +# Compile AMD PMD >>> +# >>> +CONFIG_RTE_LIBRTE_AXGBE_PMD=n >> >> Hi Ravi, >> >> This is a new networking driver from AMD. Great to see new vendors in DPDK, welcome. >> >> Patch 2/4 seems missing in the mail list, it may be stuck because of the size limit if it is a big patch, which may mean it needs to be split into multiple patches :) >> >> Thanks, >> ferruh > > Hi Ferruh, > > Thanks a lot. The Patch 2/4 got posted just now. It will be great to get review comments on the same. At first glance: - There is a new licensing, that needs to be approved. - patch 2/4 is big and hard to review properly, is it possible to have multiple incremental patches, there are good previous samples of this. - Can you please update release notes to announce new PMD? - ICC is giving build error [1], but this can be handled later. [1] #pragma GCC diagnostic ignored "-Wcast-qual" > > Regards, > Ravi <...>