Re: [dpdk-dev] [PATCH 2/4] net/vhost: allocate iface_name from heap

[Maxime Coquelin <maxime.coquelin@redhat.com>]

No variable or function names in the title, as per the contribution
guidelines:

net/vhost: allocate interface name from heap

On 1/9/20 12:22 AM, Itsuro Oda wrote:
> allocate iface_name of pmd_internal from heap in order to
> be able to refer from secondary processes.

As for patch, better to have a full sentence.

And remember to add Fixes tag and cc stable.

> Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
> ---
>  drivers/net/vhost/rte_eth_vhost.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index d4e3485ce..1b07aad24 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1007,7 +1007,7 @@ eth_dev_close(struct rte_eth_dev *dev)
>  		for (i = 0; i < dev->data->nb_tx_queues; i++)
>  			rte_free(dev->data->tx_queues[i]);
>  
> -	free(internal->iface_name);
> +	rte_free(internal->iface_name);
>  	rte_free(internal);
>  
>  	dev->data->dev_private = NULL;
> @@ -1251,9 +1251,11 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,
>  	 * - and point eth_dev structure to new eth_dev_data structure
>  	 */
>  	internal = eth_dev->data->dev_private;
> -	internal->iface_name = strdup(iface_name);
> +	internal->iface_name = rte_malloc_socket(name, strlen(iface_name) + 1,
> +						 0, numa_node);
>  	if (internal->iface_name == NULL)
>  		goto error;
> +	strcpy(internal->iface_name, iface_name);
>  
>  	list->eth_dev = eth_dev;
>  	pthread_mutex_lock(&internal_list_lock);
> @@ -1301,7 +1303,7 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,
>  
>  error:
>  	if (internal)
> -		free(internal->iface_name);
> +		rte_free(internal->iface_name);
>  	rte_free(vring_state);
>  	rte_eth_dev_release_port(eth_dev);
>  	rte_free(list);
> 


When above comments taken into account:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime