From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 681D61B39C
 for <dev@dpdk.org>; Tue,  7 Nov 2017 14:54:28 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga105.fm.intel.com with ESMTP; 07 Nov 2017 05:54:26 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,359,1505804400"; d="scan'208";a="173065729"
Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.134])
 ([10.237.220.134])
 by fmsmga006.fm.intel.com with ESMTP; 07 Nov 2017 05:54:25 -0800
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Jonas Pfefferle <jpf@zurich.ibm.com>, jianfeng.tan@intel.com
References: <1509440909-8068-1-git-send-email-jpf@zurich.ibm.com>
 <10656029.OGFJoE0f1c@xps>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <55afaf0a-14cc-11b0-c7ec-21ea1bc2403f@intel.com>
Date: Tue, 7 Nov 2017 13:54:24 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <10656029.OGFJoE0f1c@xps>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mem: warn if address hint is not respected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Nov 2017 13:54:28 -0000

On 06-Nov-17 8:26 PM, Thomas Monjalon wrote:
> 31/10/2017 10:08, Jonas Pfefferle:
>> Print a warning if the --base-virtaddr hint is not respected
>> since this might lead to problems when mapping memory in
>> the secondary process.
>>
>> Signed-off-by: Jonas Pfefferle <jpf@zurich.ibm.com>
> 
> Anatoly, please review this patch.
> It does not seem to fix something, so it is candidate for 18.02.
> 

For some reason my Thunderbird ate the original email, so i'll reply to 
this one.

One nitpick would be that we're calling get_virtual_area many times and 
it would probably be a good idea to make pagesize static and call 
sysconf only once. Otherwise,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly