From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E22A0454EF; Tue, 25 Jun 2024 13:29:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 334554336F; Tue, 25 Jun 2024 13:20:22 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 3565B42DC9; Tue, 25 Jun 2024 13:18:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719314286; x=1750850286; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yBgGSiDxYI0PviOAUE05iLiAEzWSOCvod/+/UpEM9i8=; b=ZIwDn2ukVL6WXeOOFISVj6PS3omeNl6K41ZN2xJxAn0BYZ+haV66b1xI Fn6R27Gu+yeBAL8ww7JIXPt/Dl7rbiHGrhL+0buGS0huejic5QjzLlMDD 3nL4Anb+NMcPvSqrLMYr2UayH0yA1/iYCvJJJfm5JSab6+NHZO536JONO WL0KrEwc3AJMkPb03VFvgZQRQBIk8O9Lj0TKQ5QXh5255TgvExMLucXg1 h6SrKBEZz0LVF9ZCTjR3yk4jA9gIROFHluu4K2gmolKX3SE758o4CT9wc IND5PHwdQYWU2E+VfE8q0Fw8yYIPaNE3K0aWTkXamBQKkZlxyNOMD8p8D g==; X-CSE-ConnectionGUID: v3YaUUMfTSqvlKYf3WddFQ== X-CSE-MsgGUID: DF/WRg5pRX6Pj/bcbsSNNg== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="16080638" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="16080638" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 04:18:05 -0700 X-CSE-ConnectionGUID: 4nvzVCB8SgCFPyz11wzA+A== X-CSE-MsgGUID: zdveoRZiRGKeDYaDJGbztg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="43719744" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 25 Jun 2024 04:18:04 -0700 From: Anatoly Burakov To: dev@dpdk.org, Qiming Yang , Paul M Stillwell Jr , Wenzhuo Lu , Qi Zhang Cc: Yahui Cao , bruce.richardson@intel.com, ian.stokes@intel.com, stable@dpdk.org Subject: [PATCH v3 115/129] net/ice/base: fix ice_get_ctx() issue Date: Tue, 25 Jun 2024 12:14:00 +0100 Message-ID: <55b73deb5ba88e2a14ed5d5830919e5f759c7441.1719313664.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yahui Cao No need to invert mask since we only reserve the masked bits instead of clear them. Fixes: a03c714bfe0b ("net/ice/base: add two helper functions") Cc: qi.z.zhang@intel.com Cc: stable@dpdk.org Signed-off-by: Yahui Cao Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index ad9b95f75e..8fcd27a594 100644 --- a/drivers/net/ice/base/ice_common.c +++ b/drivers/net/ice/base/ice_common.c @@ -5033,7 +5033,7 @@ ice_read_byte(u8 *src_ctx, u8 *dest_ctx, const struct ice_ctx_ele *ce_info) ice_memcpy(&dest_byte, src, sizeof(dest_byte), ICE_NONDMA_TO_NONDMA); - dest_byte &= ~(mask); + dest_byte &= mask; dest_byte >>= shift_width; @@ -5073,7 +5073,7 @@ ice_read_word(u8 *src_ctx, u8 *dest_ctx, const struct ice_ctx_ele *ce_info) /* the data in the memory is stored as little endian so mask it * correctly */ - src_word &= ~(CPU_TO_LE16(mask)); + src_word &= CPU_TO_LE16(mask); /* get the data back into host order before shifting */ dest_word = LE16_TO_CPU(src_word); @@ -5124,7 +5124,7 @@ ice_read_dword(u8 *src_ctx, u8 *dest_ctx, const struct ice_ctx_ele *ce_info) /* the data in the memory is stored as little endian so mask it * correctly */ - src_dword &= ~(CPU_TO_LE32(mask)); + src_dword &= CPU_TO_LE32(mask); /* get the data back into host order before shifting */ dest_dword = LE32_TO_CPU(src_dword); @@ -5175,7 +5175,7 @@ ice_read_qword(u8 *src_ctx, u8 *dest_ctx, const struct ice_ctx_ele *ce_info) /* the data in the memory is stored as little endian so mask it * correctly */ - src_qword &= ~(CPU_TO_LE64(mask)); + src_qword &= CPU_TO_LE64(mask); /* get the data back into host order before shifting */ dest_qword = LE64_TO_CPU(src_qword); -- 2.43.0