From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4BC17A045E for ; Tue, 28 May 2019 13:46:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B1F72C55; Tue, 28 May 2019 13:46:37 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 7F83B1B05 for ; Tue, 28 May 2019 13:46:35 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id 15so2488038wmg.5 for ; Tue, 28 May 2019 04:46:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=hKRSZUQpc0X9sPY6iicPh2ksv/Bc7I7Hx3/qubH9UYk=; b=XcQarK4i/TDlhRCx+5EXax6Kj87OUaWU49kEchGJXMrDts1BOd/RXNBAWCOamX5EvE zva9pR3rySPZp43VrfH1OuQACavpD+A0AG3TMZkgSh2AG9CLMFl+Xw9OMsqhLJ5ER8Jp y49f769PrzmcMOHucQpof9mXziBVMV5Y7TrRvGlbOUaNi/Y3D1JRWtIbPKeICTdP1Kbi OlSEVaRkoc5mPFjdkCLj/Zpp7+ctP9U+jmRQzKgNdADwDMi5ILujfX75bxy+ZZm2fwzu MvmGGhU69v8H8uPmgj/DF7VuT7BdSyzY1FIX1gzOrF4xPuQ7/zuceySTvKpCrPS+FYk+ XMig== X-Gm-Message-State: APjAAAVLsn/XiFsn+HkygblHCrSXeDjWzFduAnkVRdUWbsp0T7ytzXx2 kEwQtzjavSuDRYVi7EI64s57ESyX X-Google-Smtp-Source: APXvYqyYh3orAuDjtezI4rIGK/pUFH1cmaU7h0bPezgnNgrigR+XIP0kXtHFyD1GY5SacHs+9yLvpQ== X-Received: by 2002:a7b:c939:: with SMTP id h25mr2939078wml.7.1559043994866; Tue, 28 May 2019 04:46:34 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id o12sm2809383wmh.12.2019.05.28.04.46.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 04:46:34 -0700 (PDT) Message-ID: <55cbf61e328d5e86267d245a7afb3eee6cd93a25.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Tue, 28 May 2019 12:46:33 +0100 In-Reply-To: <20190528110748.10772-6-bruce.richardson@intel.com> References: <20190527161509.50252-1-bruce.richardson@intel.com> <20190528110748.10772-1-bruce.richardson@intel.com> <20190528110748.10772-6-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 5/5] build: add libatomic dependency for 32-bit clang compile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2019-05-28 at 12:07 +0100, Bruce Richardson wrote: > When compiling with clang on 32-bit platforms, we are missing copies > of 64-bit atomic functions. We can solve this by linking against > libatomic for the drivers and libs which need those atomic ops. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > drivers/event/octeontx/meson.build | 5 +++++ > drivers/event/opdl/meson.build | 5 +++++ > lib/librte_rcu/meson.build | 5 +++++ > 3 files changed, 15 insertions(+) >=20 > diff --git a/drivers/event/octeontx/meson.build > b/drivers/event/octeontx/meson.build > index 2b74bb6..3f83be6 100644 > --- a/drivers/event/octeontx/meson.build > +++ b/drivers/event/octeontx/meson.build > @@ -11,3 +11,8 @@ sources =3D files('ssovf_worker.c', > ) > =20 > deps +=3D ['common_octeontx', 'mempool_octeontx', 'bus_vdev', > 'pmd_octeontx'] > + > +# for clang 32-bit compiles we need libatomic for 64-bit atomic ops > +if cc.get_id() =3D=3D 'clang' and dpdk_conf.get('RTE_ARCH_64') =3D=3D fa= lse > + ext_deps +=3D cc.find_library('atomic') > +endif > diff --git a/drivers/event/opdl/meson.build > b/drivers/event/opdl/meson.build > index cc6029c..e1cfb2d 100644 > --- a/drivers/event/opdl/meson.build > +++ b/drivers/event/opdl/meson.build > @@ -9,3 +9,8 @@ sources =3D files( > 'opdl_test.c', > ) > deps +=3D ['bus_vdev'] > + > +# for clang 32-bit compiles we need libatomic for 64-bit atomic ops > +if cc.get_id() =3D=3D 'clang' and dpdk_conf.get('RTE_ARCH_64') =3D=3D fa= lse > + ext_deps +=3D cc.find_library('atomic') > +endif > diff --git a/lib/librte_rcu/meson.build b/lib/librte_rcu/meson.build > index 0c2d5a2..43edb87 100644 > --- a/lib/librte_rcu/meson.build > +++ b/lib/librte_rcu/meson.build > @@ -5,3 +5,8 @@ allow_experimental_apis =3D true > =20 > sources =3D files('rte_rcu_qsbr.c') > headers =3D files('rte_rcu_qsbr.h') > + > +# for clang 32-bit compiles we need libatomic for 64-bit atomic ops > +if cc.get_id() =3D=3D 'clang' and dpdk_conf.get('RTE_ARCH_64') =3D=3D fa= lse > + ext_deps +=3D cc.find_library('atomic') > +endif Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi