From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 141D8A0513; Wed, 15 Jan 2020 13:39:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D95871BFEC; Wed, 15 Jan 2020 13:39:39 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 815DC1BFC6; Wed, 15 Jan 2020 13:39:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2020 04:39:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,322,1574150400"; d="scan'208";a="219268363" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.35]) ([10.237.221.35]) by fmsmga007.fm.intel.com with ESMTP; 15 Jan 2020 04:39:35 -0800 To: Slava Ovsiienko , "dev@dpdk.org" Cc: Thomas Monjalon , "declan.doherty@intel.com" , "stable@dpdk.org" References: <1576759626-27977-1-git-send-email-viacheslavo@mellanox.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <55d5f0aa-213d-f903-9c81-26c60c268716@intel.com> Date: Wed, 15 Jan 2020 12:39:34 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix switching domain allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/15/2020 8:50 AM, Slava Ovsiienko wrote: >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, January 14, 2020 17:32 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Thomas Monjalon ; declan.doherty@intel.com; >> stable@dpdk.org >> Subject: Re: [PATCH] ethdev: fix switching domain allocation >> >> On 12/19/2019 12:47 PM, Viacheslav Ovsiienko wrote: >>> The maximum amount of unique switching domain is supposed to be equal >>> to RTE_MAX_ETHPORTS. The current implementation allows to allocate >>> only RTE_MAX_ETHPORTS-1 domains. >>> >>> Fixes: ce9250406323 ("ethdev: add switch domain allocator") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Viacheslav Ovsiienko >>> --- >>> lib/librte_ethdev/rte_ethdev.c | 13 +++++++------ >>> 1 file changed, 7 insertions(+), 6 deletions(-) >>> >>> diff --git a/lib/librte_ethdev/rte_ethdev.c >>> b/lib/librte_ethdev/rte_ethdev.c index 6e9cb24..4c2312c 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.c >>> +++ b/lib/librte_ethdev/rte_ethdev.c >>> @@ -5065,10 +5065,10 @@ enum rte_eth_switch_domain_state { >>> *domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID; >>> >>> for (i = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID + 1; >>> - i < RTE_MAX_ETHPORTS; i++) { >>> - if (rte_eth_switch_domains[i].state == >>> + i <= RTE_MAX_ETHPORTS; i++) { >>> + if (rte_eth_switch_domains[i - 1].state == >>> RTE_ETH_SWITCH_DOMAIN_UNUSED) { >>> - rte_eth_switch_domains[i].state = >>> + rte_eth_switch_domains[i - 1].state = >>> RTE_ETH_SWITCH_DOMAIN_ALLOCATED; >>> *domain_id = i; >> >> I would keep the indexes same but change how to set the 'domain_id' to >> "*domain_id = i + 1;", that makes logic simpler. > Agree. > >> Would it be simpler if the invalid domain id value used as UINT16_MAX >> instead of '0'? This enables using 'domain_id' as index and prevent this error >> prone indexing. > > My concern was not to change the existing RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID > definition, which currently is zero. Currently, AFAIK, the switch feature is supported by mlx5 > only, other PMDs do not bother to initialize the rte_eth_dev_info-> switch_info structure > (no one sets RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID to domain_id field for now). > So, changing the RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID from zero might cause > wrong switch capability reporting from PMDs. I think PMDs shouldn't have to initialize the values that they don't use/care, otherwise it will be very error prone. Can this be handled in the API level? Like in 'rte_eth_dev_info_get()', after "memset(dev_info, ..)" set 'switch_info' as INVALID before dev_ops called. PMD can overwrite this if they want, otherwise it will stay invalid and I think this is safer. > >> >> And I think it makes sense to start the loop with "i = 0", instead of >> 'RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID', you are walking through the >> port list, why to involve the 'RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID' >> here. > I do not know why it was implemented in this way 😊 > I just was trying to introduce the minimalistic fix. I'll think how to extend my fix a bit. > >> >>> return 0; >>> @@ -5082,14 +5082,15 @@ enum rte_eth_switch_domain_state { >>> rte_eth_switch_domain_free(uint16_t domain_id) { >>> if (domain_id == RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID || >>> - domain_id >= RTE_MAX_ETHPORTS) >>> + domain_id > RTE_MAX_ETHPORTS) >>> return -EINVAL; >>> >>> - if (rte_eth_switch_domains[domain_id].state != >>> + if (rte_eth_switch_domains[domain_id - 1].state != >>> RTE_ETH_SWITCH_DOMAIN_ALLOCATED) >>> return -EINVAL; >>> >>> - rte_eth_switch_domains[domain_id].state = >> RTE_ETH_SWITCH_DOMAIN_UNUSED; >>> + rte_eth_switch_domains[domain_id - 1].state = >>> + RTE_ETH_SWITCH_DOMAIN_UNUSED; >>> >>> return 0; >>> } >>> > With best regards, > Slava >