From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C1E90A04DB;
	Wed, 14 Oct 2020 19:29:22 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 1E9331DA79;
	Wed, 14 Oct 2020 19:29:21 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id EAD791D546
 for <dev@dpdk.org>; Wed, 14 Oct 2020 19:29:18 +0200 (CEST)
IronPort-SDR: oqtIcDnPr4xsTyjWLifE+t8/R7Bhf9ZF1aWxOTHmq6ROop8IyOfoaGVYkBvlMnvqA86dSqv03G
 L92lRu+oPQVg==
X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="165365842"
X-IronPort-AV: E=Sophos;i="5.77,375,1596524400"; d="scan'208";a="165365842"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 14 Oct 2020 10:29:18 -0700
IronPort-SDR: 9AWyXr6WoyEPcJ+7r4LxE2NEgmnA/MxieRNDQ0Fix0QC7rm6JqPppYSG/JNv0xuo26klXTtoIk
 31nQzVPN99Sw==
X-IronPort-AV: E=Sophos;i="5.77,375,1596524400"; d="scan'208";a="463962004"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.212.224])
 ([10.213.212.224])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 14 Oct 2020 10:29:15 -0700
To: Andrew Rybchenko <arybchenko@solarflare.com>, Ray Kinsella
 <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
References: <1602682146-4722-1-git-send-email-arybchenko@solarflare.com>
 <1602682146-4722-2-git-send-email-arybchenko@solarflare.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <55f30269-ef8d-fe37-409d-f90e2ae571a8@intel.com>
Date: Wed, 14 Oct 2020 18:29:12 +0100
MIME-Version: 1.0
In-Reply-To: <1602682146-4722-2-git-send-email-arybchenko@solarflare.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 01/11] ethdev: change eth dev stop function
	to return int
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/14/2020 2:28 PM, Andrew Rybchenko wrote:
> From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
> 
> Change rte_eth_dev_stop() return value from void to int
> and return negative errno values in case of error conditions.
> Also update the usage of the function in ethdev according to
> the new return type.
> 
> Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

<...>

> @@ -2278,7 +2278,7 @@ int rte_eth_dev_start(uint16_t port_id);
>    * @param port_id
>    *   The port identifier of the Ethernet device.
>    */
> -void rte_eth_dev_stop(uint16_t port_id);
> +int rte_eth_dev_stop(uint16_t port_id);
>   

Doxygen comment should be updated for return value.