From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 398E51B817 for ; Mon, 9 Apr 2018 16:38:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 07:38:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,427,1517904000"; d="scan'208";a="46340536" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.112]) ([163.33.230.112]) by orsmga001.jf.intel.com with ESMTP; 09 Apr 2018 07:38:30 -0700 To: Shreyansh Jain , dev@dpdk.org References: <20180406145002.27480-1-remy.horton@intel.com> <20180406145002.27480-5-remy.horton@intel.com> Cc: John McNamara , Wenzhuo Lu , Jingjing Wu , Qi Zhang , Beilei Xing , Thomas Monjalon From: Remy Horton Organization: Intel Shannon Limited Message-ID: <560b67af-3650-7be6-d4d6-b0de6bf00c0c@intel.com> Date: Mon, 9 Apr 2018 15:38:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 14:38:35 -0000 On 09/04/2018 13:55, Shreyansh Jain wrote: [..] > Documentation for burst mode changes to testpmd would need an update. > I guess, only when the user explicitly sets 'set burst 0' would the > driver defaults be picked up - isn't it? Yes. > Maybe something like this: > > --->8--- > --- a/doc/guides/testpmd_app_ug/run_app.rst > +++ b/doc/guides/testpmd_app_ug/run_app.rst > @@ -372,7 +372,9 @@ The commandline options are: > * ``--burst=N`` > > Set the number of packets per burst to N, where 1 <= N <= 512. > - The default value is 16. > + The default value is 32. > + If set to 0, driver default is used if defined. Else, if driver > default > + is not defined, default of 32 is used. > > * ``--mbcache=N`` > --->8--- > > In the above, I think the existing documented default value needs to be > changed. It is set to '#define DEF_PKT_BURST 32' Had a quick look and it looks like that discrepancy has been there since the documentation was converted to .rst in 2014. > If you add that, please use my ack for next revision. > (For patch 1/4, I had already given my Ack in v2) I'll add in the snippet above. 18.05 integration deadline has I think passed, but documentation changes will still get in.