From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AC4757D0B for ; Wed, 18 Apr 2018 08:21:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 23:21:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="217455569" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga005.jf.intel.com with ESMTP; 17 Apr 2018 23:21:28 -0700 Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.99]) by PGSMSX104.gar.corp.intel.com ([169.254.3.189]) with mapi id 14.03.0319.002; Wed, 18 Apr 2018 14:21:27 +0800 From: "Gujjar, Abhinandan S" To: Akhil Goyal , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "Doherty, Declan" , "Vangati, Narender" , "Rao, Nikhil" , "Eads, Gage" Thread-Topic: [dpdk-dev, v1, 2/5] eventdev: add crypto adapter implementation Thread-Index: AQHT1lcTQotuUXI2n0Spzo6oA0XnV6QGCHJA Date: Wed, 18 Apr 2018 06:21:27 +0000 Message-ID: <5612CB344B05EE4F95FC5B729939F780706E5DA8@PGSMSX102.gar.corp.intel.com> References: <1522824999-61614-1-git-send-email-abhinandan.gujjar@intel.com> <5ea61576-9124-266a-00e6-cb9f22a37f59@nxp.com> In-Reply-To: <5ea61576-9124-266a-00e6-cb9f22a37f59@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmI3ZmU3NTMtOTgyYS00MmFkLWE2ZWQtNDQ4NjYwMjkxZTc4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjNuaVMzZVVYNG9XS1g1SkxBODE5Y1JoSkJGSjNDQzZVQXByeHp2MmNHeHc9In0= dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-dev, v1, 2/5] eventdev: add crypto adapter implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 06:21:32 -0000 Hi Akhil, Please find the comments inline. > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, April 17, 2018 7:48 PM > To: Gujjar, Abhinandan S ; > jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Doherty, Decl= an > ; Vangati, Narender > ; Rao, Nikhil ; Eads, G= age > > Subject: Re: [dpdk-dev, v1, 2/5] eventdev: add crypto adapter implementat= ion >=20 > Hi Abhinandan, >=20 > I have not reviewed the patch completely. But I have below query for furt= her > review. > On 4/4/2018 12:26 PM, Abhinandan Gujjar wrote: > > Signed-off-by: Abhinandan Gujjar > > Signed-off-by: Nikhil Rao > > Signed-off-by: Gage Eads > > --- >=20 > [..snip..] > > + > > +int __rte_experimental > > +rte_event_crypto_adapter_queue_pair_add(uint8_t id, > > + uint8_t cdev_id, > > + int32_t queue_pair_id) > > +{ > > + struct rte_event_crypto_adapter *adapter; > > + struct rte_eventdev *dev; > > + struct crypto_device_info *dev_info; > > + uint32_t cap; > > + int ret; > > + > > + RTE_EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL); > > + > > + if (!rte_cryptodev_pmd_is_valid_dev(cdev_id)) { > > + RTE_EDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, cdev_id); > > + return -EINVAL; > > + } > > + > > + adapter =3D eca_id_to_adapter(id); > > + if (adapter =3D=3D NULL) > > + return -EINVAL; > > + > > + dev =3D &rte_eventdevs[adapter->eventdev_id]; > > + ret =3D rte_event_crypto_adapter_caps_get(adapter->eventdev_id, > > + cdev_id, > > + &cap); > > + if (ret) { > > + RTE_EDEV_LOG_ERR("Failed to get adapter caps dev %" PRIu8 > > + "cdev %" PRIu8, id, cdev_id); > > + return ret; > > + } > > + > > + dev_info =3D &adapter->cdevs[cdev_id]; > > + > > + if (queue_pair_id !=3D -1 && > > + (uint16_t)queue_pair_id >=3D dev_info->dev->data->nb_queue_pairs)= { > > + RTE_EDEV_LOG_ERR("Invalid queue_pair_id %" PRIu16, > > + (uint16_t)queue_pair_id); > > + return -EINVAL; > > + } > > + > > + if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT) { > > + RTE_FUNC_PTR_OR_ERR_RET( > > + *dev->dev_ops->crypto_adapter_queue_pair_add, > > + -ENOTSUP); > > + if (dev_info->qpairs =3D=3D NULL) { > > + dev_info->qpairs =3D > > + rte_zmalloc_socket(adapter->mem_name, > > + dev_info->dev->data->nb_queue_pairs > * > > + sizeof(struct crypto_queue_pair_info), > > + 0, adapter->socket_id); > > + if (dev_info->qpairs =3D=3D NULL) > > + return -ENOMEM; > > + } > > + > > + ret =3D (*dev->dev_ops->crypto_adapter_queue_pair_add)(dev, > > + dev_info->dev, > > + queue_pair_id); >=20 > crypto_adapter_queue_pair_add is supposed to attach a queue > (queue_pair_id) of cryptodev(dev_info->dev) to event device (dev). > But how will the underlying implementation attach it to event device with= out > knowing the eventdev queue_id. This information was coming in the RFC > patches with the parameter (rte_event_crypto_queue_pair_conf). > Why is this removed and if removed how will the driver attach the queue. > I can see that rte_event is passed in the session private data but how ca= n we > attach the crypto queue with event dev queue? Yes, this was present in the first version of the RFC which is similar to e= th rx adapter. After couple of discussions, thread http://dpdk.org/dev/patchwork/patch/317= 52/), it was changed. In eth rx adapter, eth queues are mapped to eventdev, where= as in crypto adapter the sessions are mapped to eventdev. Since event info is present al= ong with the session, the get API has to be called in respective API to get the event in= formation and then map to eventdev. Regards Abhinandan >=20 > Regards, > Akhil