From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 094B95F65 for ; Tue, 8 May 2018 10:39:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2018 01:39:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,377,1520924400"; d="scan'208";a="53344827" Received: from pgsmsx111.gar.corp.intel.com ([10.108.55.200]) by fmsmga001.fm.intel.com with ESMTP; 08 May 2018 01:39:54 -0700 Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.245]) by PGSMSX111.gar.corp.intel.com ([169.254.2.194]) with mapi id 14.03.0319.002; Tue, 8 May 2018 16:39:23 +0800 From: "Gujjar, Abhinandan S" To: Jerin Jacob CC: "hemant.agrawal@nxp.com" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" , "Eads, Gage" Thread-Topic: [v3,2/5] eventdev: add APIs and PMD callbacks for crypto adapter Thread-Index: AQHT5KFurSKuWLBWhkeeSYAtSg2X4aQjguWAgAICg+A= Date: Tue, 8 May 2018 08:39:22 +0000 Message-ID: <5612CB344B05EE4F95FC5B729939F78070703648@PGSMSX102.gar.corp.intel.com> References: <1525546030-11204-1-git-send-email-abhinandan.gujjar@intel.com> <1525546030-11204-3-git-send-email-abhinandan.gujjar@intel.com> <20180507095238.GA9245@jerin> In-Reply-To: <20180507095238.GA9245@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v3, 2/5] eventdev: add APIs and PMD callbacks for crypto adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 08:39:57 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, May 7, 2018 3:23 PM > To: Gujjar, Abhinandan S > Cc: hemant.agrawal@nxp.com; akhil.goyal@nxp.com; dev@dpdk.org; Vangati, > Narender ; Rao, Nikhil = ; > Eads, Gage > Subject: Re: [v3,2/5] eventdev: add APIs and PMD callbacks for crypto ada= pter >=20 > -----Original Message----- > > Date: Sun, 6 May 2018 00:17:07 +0530 > > From: Abhinandan Gujjar > > To: jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, > > akhil.goyal@nxp.com, dev@dpdk.org > > CC: narender.vangati@intel.com, abhinandan.gujjar@intel.com, > > nikhil.rao@intel.com, gage.eads@intel.com > > Subject: [v3,2/5] eventdev: add APIs and PMD callbacks for crypto > > adapter > > X-Mailer: git-send-email 1.9.1 > > > > Signed-off-by: Abhinandan Gujjar > > --- > > drivers/event/sw/sw_evdev.c | 13 +++ > > lib/librte_eventdev/rte_eventdev.c | 25 +++++ > > lib/librte_eventdev/rte_eventdev.h | 54 ++++++++++ > > lib/librte_eventdev/rte_eventdev_pmd.h | 187 > > +++++++++++++++++++++++++++++++++ > > 4 files changed, 279 insertions(+) > > > > --- a/lib/librte_eventdev/rte_eventdev.h > > +++ b/lib/librte_eventdev/rte_eventdev.h > > @@ -8,6 +8,8 @@ > > #ifndef _RTE_EVENTDEV_H_ > > #define _RTE_EVENTDEV_H_ > > > > +#include >=20 > Why rte_compat.h ? Is it by mistake? I could compile without this change. Just notice that, I too got a successful compilation without this file. Initially, I got an error when APIs were marked as rte_experimental. Then, = I had to include this file! May be this file is included somewhere else. Anyway, I will remove it. >=20 > > + > > /** > > * @file > > * > > @@ -1135,6 +1137,58 @@ struct rte_event { int __rte_experimental > > rte_event_timer_adapter_caps_get(uint8_t dev_id, uint32_t *caps); > > > > @@ -70,6 +70,9 @@ > > ((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | \ > > > (RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ)) > > > > +#define RTE_EVENT_CRYPTO_ADAPTER_SW_CAP \ > > + RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA >=20 > I thought, SW driver has support for > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND. > If not, please ignore this comment. >=20 >=20 > With above changes: > Acked-by: Jerin Jacob