Re: [dpdk-dev] [v4,1/5] eventdev: introduce event crypto adapter

["Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>]

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, May 9, 2018 12:32 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com;
> akhil.goyal@nxp.com; dev@dpdk.org
> Cc: Vangati, Narender <narender.vangati@intel.com>; Rao, Nikhil
> <nikhil.rao@intel.com>; Eads, Gage <gage.eads@intel.com>
> Subject: Re: [dpdk-dev] [v4,1/5] eventdev: introduce event crypto adapter
> 
> On 5/9/2018 1:16 AM, Abhinandan Gujjar wrote:
> > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
> > ---
> [...]
> 
> > +
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this structure may change without prior notice
> > + *
> > + * Crypto event metadata structure will be filled by application
> > + * to provide crypto request and event response information.
> > + *
> > + * If crypto events are enqueued using a HW mechanism, the cryptodev
> > + * PMD will use the event response information to set up the event
> > + * that is enqueued back to eventdev after completion of the crypto
> > + * operation. If the transfer is done by SW, event response information
> > + * will be used by the adapter.
> > + */
> > +union rte_event_crypto_metadata {
> > +	struct rte_event_crypto_request request_info;
> > +	/**< Request information to be filled in by application
> > +	 * for RTE_EVENT_CRYPTO_ADAPTER_OP_NEW mode.
> > +	 */
> > +	struct rte_event response_info;
> > +	/**< Response information to be filled in by application
> > +	 * for RTE_EVENT_CRYPTO_ADAPTER_OP_NEW and
> > +	 * RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode.
> > +	 */
> > +};
> I think the comments are not correct. It was correct in previous version.
> request is for only forward mode and response is for both.
Thanks for catching this. I will update this in the next patch.
> 
> Apart from this:
> 
> Patch Series
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>