From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <abhinandan.gujjar@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id 136808DAE
for <dev@dpdk.org>; Wed, 9 May 2018 09:26:18 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
09 May 2018 00:26:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,381,1520924400"; d="scan'208";a="39558408"
Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103])
by orsmga007.jf.intel.com with ESMTP; 09 May 2018 00:26:15 -0700
Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.245]) by
PGSMSX108.gar.corp.intel.com ([169.254.8.47]) with mapi id 14.03.0319.002;
Wed, 9 May 2018 15:26:14 +0800
From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "jerin.jacob@caviumnetworks.com"
<jerin.jacob@caviumnetworks.com>, "hemant.agrawal@nxp.com"
<hemant.agrawal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Vangati, Narender" <narender.vangati@intel.com>, "Rao, Nikhil"
<nikhil.rao@intel.com>, "Eads, Gage" <gage.eads@intel.com>
Thread-Topic: [dpdk-dev] [v4,1/5] eventdev: introduce event crypto adapter
Thread-Index: AQHT5wUjC7B+cKUumUunW+53Z3OSX6QmcwyAgACMnbA=
Date: Wed, 9 May 2018 07:26:13 +0000
Message-ID: <5612CB344B05EE4F95FC5B729939F78070703FD6@PGSMSX102.gar.corp.intel.com>
References: <1525808764-109595-1-git-send-email-abhinandan.gujjar@intel.com>
<1525808764-109595-2-git-send-email-abhinandan.gujjar@intel.com>
<479d6bf8-c0aa-620a-1946-0a209a279c59@nxp.com>
In-Reply-To: <479d6bf8-c0aa-620a-1946-0a209a279c59@nxp.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [172.30.20.206]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [v4,1/5] eventdev: introduce event crypto adapter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 May 2018 07:26:19 -0000
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, May 9, 2018 12:32 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com;
> akhil.goyal@nxp.com; dev@dpdk.org
> Cc: Vangati, Narender <narender.vangati@intel.com>; Rao, Nikhil
> <nikhil.rao@intel.com>; Eads, Gage <gage.eads@intel.com>
> Subject: Re: [dpdk-dev] [v4,1/5] eventdev: introduce event crypto adapter
>=20
> On 5/9/2018 1:16 AM, Abhinandan Gujjar wrote:
> > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
> > ---
> [...]
>=20
> > +
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this structure may change without prior notice
> > + *
> > + * Crypto event metadata structure will be filled by application
> > + * to provide crypto request and event response information.
> > + *
> > + * If crypto events are enqueued using a HW mechanism, the cryptodev
> > + * PMD will use the event response information to set up the event
> > + * that is enqueued back to eventdev after completion of the crypto
> > + * operation. If the transfer is done by SW, event response informatio=
n
> > + * will be used by the adapter.
> > + */
> > +union rte_event_crypto_metadata {
> > + struct rte_event_crypto_request request_info;
> > + /**< Request information to be filled in by application
> > + * for RTE_EVENT_CRYPTO_ADAPTER_OP_NEW mode.
> > + */
> > + struct rte_event response_info;
> > + /**< Response information to be filled in by application
> > + * for RTE_EVENT_CRYPTO_ADAPTER_OP_NEW and
> > + * RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode.
> > + */
> > +};
> I think the comments are not correct. It was correct in previous version.
> request is for only forward mode and response is for both.
Thanks for catching this. I will update this in the next patch.
>=20
> Apart from this:
>=20
> Patch Series
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>