Re: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test

["Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>]

Hi Pablo,

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, May 10, 2018 9:23 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com;
> akhil.goyal@nxp.com; dev@dpdk.org
> Cc: Vangati, Narender <narender.vangati@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; Rao, Nikhil <nikhil.rao@intel.com>; Eads,
> Gage <gage.eads@intel.com>
> Subject: RE: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Abhinandan
> Gujjar
> > Sent: Wednesday, May 9, 2018 9:18 AM
> > To: jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com;
> > akhil.goyal@nxp.com; dev@dpdk.org
> > Cc: Vangati, Narender <narender.vangati@intel.com>; Gujjar, Abhinandan
> > S <abhinandan.gujjar@intel.com>; Rao, Nikhil <nikhil.rao@intel.com>;
> > Eads, Gage <gage.eads@intel.com>
> > Subject: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test
> >
> > Added testsuite to test the crypto adapter functionality.
> > The testsuite detects the HW/SW event & crypto devices and their
> capabilities.
> > Depending upon the capability, adapter is confgured and modes are
> tested.
> >
> > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> ...
> 
> > +	/*
> > +	 * Create mempool with maximum number of sessions * 2,
> > +	 * to include the session headers & private data
> > +	 */
> > +	session_size =
> rte_cryptodev_get_private_session_size(TEST_CDEV_ID);
> > +	session_size += sizeof(union rte_event_crypto_metadata);
> > +
> > +	params.session_mpool = rte_mempool_create(
> > +				"CRYPTO_ADAPTER_SESSION_MP",
> > +				info.sym.max_nb_sessions * 2,
> > +				session_size,
> > +				0, 0, NULL, NULL, NULL,
> > +				NULL, SOCKET_ID_ANY,
> > +				0);
> 
> I am seeing an icc compilation issue here:
> 
> test/test/test_event_crypto_adapter.c(530): error #592: variable "info" is
> used before its v                                                                 alue is set
>                                 info.sym.max_nb_sessions * 2,
> 
> Looking at this, info gets filled below, after using it in mempool_create, which
> looks wrong.
> But also, keep in mind that we are going to remove max_nb_sessions, since
> this was used when the session pool was created inside the PMD.
> 
> I suggest to set your own number of session in the test and not use
> max_nb_sessions.

Thanks for reporting this. I will send a separate patch to fix this.

Regards
Abhinandan

> 
> Thanks,
> Pablo