From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 746B71C648 for ; Fri, 11 May 2018 14:56:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 May 2018 05:56:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,388,1520924400"; d="scan'208";a="227670884" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by fmsmga005.fm.intel.com with ESMTP; 11 May 2018 05:56:23 -0700 Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.245]) by PGSMSX105.gar.corp.intel.com ([169.254.4.60]) with mapi id 14.03.0319.002; Fri, 11 May 2018 20:56:22 +0800 From: "Gujjar, Abhinandan S" To: "De Lara Guarch, Pablo" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "akhil.goyal@nxp.com" , "dev@dpdk.org" CC: "Vangati, Narender" , "Rao, Nikhil" , "Eads, Gage" Thread-Topic: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test Thread-Index: AQHT525FfZGggQ+0dE+WM0Lb9rD6O6QomPKAgAHjPCA= Date: Fri, 11 May 2018 12:56:21 +0000 Message-ID: <5612CB344B05EE4F95FC5B729939F78070705559@PGSMSX102.gar.corp.intel.com> References: <1525853881-140647-1-git-send-email-abhinandan.gujjar@intel.com> <1525853881-140647-5-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjZiMzdhOTUtZTIwYS00MDIzLTgzZjQtMDJiZjE3NjYyYWE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQXRBUnYzWm5iVDVpRktrQzRZdm5IOEhLT0VHaHE2ampuK0JEVUZxXC9LMGJMeHU4RGFrd3NGV2VhQ282UXM3RWkifQ== dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 12:56:26 -0000 Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, May 10, 2018 9:23 PM > To: Gujjar, Abhinandan S ; > jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; > akhil.goyal@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Gujjar, Abhinandan S > ; Rao, Nikhil ; Eads, > Gage > Subject: RE: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Abhinandan > Gujjar > > Sent: Wednesday, May 9, 2018 9:18 AM > > To: jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; > > akhil.goyal@nxp.com; dev@dpdk.org > > Cc: Vangati, Narender ; Gujjar, Abhinandan > > S ; Rao, Nikhil ; > > Eads, Gage > > Subject: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test > > > > Added testsuite to test the crypto adapter functionality. > > The testsuite detects the HW/SW event & crypto devices and their > capabilities. > > Depending upon the capability, adapter is confgured and modes are > tested. > > > > Signed-off-by: Abhinandan Gujjar > > Acked-by: Akhil Goyal >=20 > ... >=20 > > + /* > > + * Create mempool with maximum number of sessions * 2, > > + * to include the session headers & private data > > + */ > > + session_size =3D > rte_cryptodev_get_private_session_size(TEST_CDEV_ID); > > + session_size +=3D sizeof(union rte_event_crypto_metadata); > > + > > + params.session_mpool =3D rte_mempool_create( > > + "CRYPTO_ADAPTER_SESSION_MP", > > + info.sym.max_nb_sessions * 2, > > + session_size, > > + 0, 0, NULL, NULL, NULL, > > + NULL, SOCKET_ID_ANY, > > + 0); >=20 > I am seeing an icc compilation issue here: >=20 > test/test/test_event_crypto_adapter.c(530): error #592: variable "info" i= s > used before its v = alue is set > info.sym.max_nb_sessions * 2, >=20 > Looking at this, info gets filled below, after using it in mempool_create= , which > looks wrong. > But also, keep in mind that we are going to remove max_nb_sessions, since > this was used when the session pool was created inside the PMD. >=20 > I suggest to set your own number of session in the test and not use > max_nb_sessions. Thanks for reporting this. I will send a separate patch to fix this. Regards Abhinandan >=20 > Thanks, > Pablo