DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] test/event_crypto: add check for session init failure
Date: Thu, 12 Sep 2019 15:08:03 +0000	[thread overview]
Message-ID: <5612CB344B05EE4F95FC5B729939F78079540FFE@PGSMSX102.gar.corp.intel.com> (raw)
In-Reply-To: <20190906104228.15271-1-hemant.agrawal@nxp.com>

Acked-by: abhinandan.gujjar@intel.com

> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Friday, September 6, 2019 4:12 PM
> To: dev@dpdk.org
> Cc: jerinj@marvell.com; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: [PATCH] test/event_crypto: add check for session init failure
> 
> Mismatch in algo or sec capability can cause session to fail.
> This patch handle it and return error timely.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  app/test/test_event_crypto_adapter.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 73655020d..e7bf80978 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -199,8 +199,9 @@ test_op_forward_mode(uint8_t session_less)
>  		TEST_ASSERT_NOT_NULL(sess, "Session creation failed\n");
> 
>  		/* Create Crypto session*/
> -		rte_cryptodev_sym_session_init(TEST_CDEV_ID, sess,
> +		ret = rte_cryptodev_sym_session_init(TEST_CDEV_ID, sess,
>  				&cipher_xform, params.session_priv_mpool);
> +		TEST_ASSERT_SUCCESS(ret, "Failed to init session\n");
> 
>  		ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
>  							evdev, &cap);
> @@ -398,8 +399,10 @@ test_op_new_mode(uint8_t session_less)
>  			rte_cryptodev_sym_session_set_user_data(sess,
>  						&m_data, sizeof(m_data));
>  		}
> -		rte_cryptodev_sym_session_init(TEST_CDEV_ID, sess,
> +		ret = rte_cryptodev_sym_session_init(TEST_CDEV_ID, sess,
>  				&cipher_xform, params.session_priv_mpool);
> +		TEST_ASSERT_SUCCESS(ret, "Failed to init session\n");
> +
>  		rte_crypto_op_attach_sym_session(op, sess);
>  	} else {
>  		struct rte_crypto_sym_xform *first_xform;
> --
> 2.17.1


  reply	other threads:[~2019-09-12 15:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 10:42 Hemant Agrawal
2019-09-12 15:08 ` Gujjar, Abhinandan S [this message]
2019-09-13 10:28   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5612CB344B05EE4F95FC5B729939F78079540FFE@PGSMSX102.gar.corp.intel.com \
    --to=abhinandan.gujjar@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).