From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix build error with kernel < 3.2
Date: Mon, 03 Apr 2017 19:48:51 +0200 [thread overview]
Message-ID: <5615532.S2nOutNl0d@xps13> (raw)
In-Reply-To: <20170403164901.13133-1-ferruh.yigit@intel.com>
2017-04-03 17:49, Ferruh Yigit:
> Recently added "dma_zalloc_coherent()" call is causing build error
> for Linux kernels < 3.2.
>
> compile error:
> .../build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:
> In function ‘igbuio_pci_probe’:
> .../build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:434:2:
> error: implicit declaration of function ‘dma_zalloc_coherent’
> [-Werror=implicit-function-declaration]
> map_addr = dma_zalloc_coherent(&dev->dev, 1024,
> ^
>
> dma_zalloc_coherent() introduced with Linux kernel 3.2, with commit
> Linux: 842fa69f3e0c ("include/linux/dma-mapping.h: add dma_zalloc_coherent()")
> Since it does not exist for older kernels, causing a build error.
>
> Swithched to dma_alloc_coherent() API to prevent build error.
>
> Fixes: d287e4d41be0 ("igb_uio: map dummy DMA forcing IOMMU domain attachment")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-04-03 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 16:49 Ferruh Yigit
2017-04-03 17:48 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5615532.S2nOutNl0d@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).