From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 6B37C2BF5 for ; Mon, 3 Apr 2017 19:48:54 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id w43so179164810wrb.0 for ; Mon, 03 Apr 2017 10:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=/P/rIOFwwnfFO9NxcVZtnaLkIpDaJLiJFo4tCdn7TJE=; b=cFEKqJeuP7ijEOwA3WsxTmKh2rED+VmjNely3YorF2/ny4jVchLucy4n72htRwZa04 vWDmYqKVbBW1d2zh2d5wfNYsfdD1OL3g0dvUsyyHjbQQ89r9PRQNqeLdGU56EneFwVte LoxMgfOdTThX5rKif6F5y6yq2Y61tcTGxLBK/6x/bh9f01HP7MzbKwA9vvtCeYfgfQ4V 22vGAUjSFARNE9xuZCH0v45UyCYouIhjuYPeRfL+kp8NY/2ShFRUgSdGkwZCogoWbAAP qph34nLqMGX8bJYiDHMOGifnIMPp6gf6LtZo7Ye6UOFN5cvgaONxnISAoH+4O+Y81Q+o 6WMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=/P/rIOFwwnfFO9NxcVZtnaLkIpDaJLiJFo4tCdn7TJE=; b=uQzY/R89b/paU0RfQNsYFWUcm4L7P/wtj2s11lUkBeGCmiVX+Chaxg6+3YqO4Hx19u pG/nxAlyTUVSHrHqkw/QnkQkhv+H4fm1qODvxd0axBdHIHAxKmwG62b0/XB8WiexUTa7 Xcq+fCCnKkxx428lSJWxHEkdu0EGaSGwy9gnci0U82ViYw8DUF/1Q4r4TVJz5eXjhHfj 49apE1f0cski/aDbWkPAVNaBk9EiSUEL171sVPZubD+pbvdVlqfxyuz8fZ0uIBPBCg07 ZzFu2qYxK/buJroByqblnR9afgUMJCB9IH0Ympfe+YBFfZw/2+qGBMepIqkccg3wRK/E 9MRA== X-Gm-Message-State: AFeK/H3QJoDB0aFsXKnWPY7hdT4SysPWboIkbwujWSn3KSz7gplRkCBAtVIUf1xa+/6Ziahc X-Received: by 10.28.128.209 with SMTP id b200mr11408988wmd.140.1491241733626; Mon, 03 Apr 2017 10:48:53 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c8sm19047412wrd.57.2017.04.03.10.48.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Apr 2017 10:48:52 -0700 (PDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Mon, 03 Apr 2017 19:48:51 +0200 Message-ID: <5615532.S2nOutNl0d@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170403164901.13133-1-ferruh.yigit@intel.com> References: <20170403164901.13133-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix build error with kernel < 3.2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2017 17:48:54 -0000 2017-04-03 17:49, Ferruh Yigit: > Recently added "dma_zalloc_coherent()" call is causing build error > for Linux kernels < 3.2. >=20 > compile error: > .../build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c: > In function =E2=80=98igbuio_pci_probe=E2=80=99: > .../build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:434:2: > error: implicit declaration of function =E2=80=98dma_zalloc_coherent=E2= =80=99 > [-Werror=3Dimplicit-function-declaration] > map_addr =3D dma_zalloc_coherent(&dev->dev, 1024, > ^ >=20 > dma_zalloc_coherent() introduced with Linux kernel 3.2, with commit > Linux: 842fa69f3e0c ("include/linux/dma-mapping.h: add dma_zalloc_coh= erent()") > Since it does not exist for older kernels, causing a build error. >=20 > Swithched to dma_alloc_coherent() API to prevent build error. >=20 > Fixes: d287e4d41be0 ("igb_uio: map dummy DMA forcing IOMMU domain att= achment") >=20 > Signed-off-by: Ferruh Yigit Applied, thanks