From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D66DB2BD5 for ; Fri, 22 Feb 2019 17:43:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2019 08:43:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,400,1544515200"; d="scan'208";a="136420825" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.114]) ([10.237.221.114]) by orsmga002.jf.intel.com with ESMTP; 22 Feb 2019 08:43:29 -0800 To: Leyi Rong , jingjing.wu@intel.com, wenzhuo.lu@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org References: <20190222150336.22299-1-leyi.rong@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <5615a7c5-3204-fa69-8119-068be2b0e9fa@intel.com> Date: Fri, 22 Feb 2019 16:43:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190222150336.22299-1-leyi.rong@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/iavf: rename avf to iavf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2019 16:43:33 -0000 On 2/22/2019 3:03 PM, Leyi Rong wrote: > Rename Intel Ethernet Adaptive Virtual Function driver avf to iavf. > > This patch renames the directory name, filenames, lib name, macros, > functions, structs and any other strings in the iavf src code. > > Signed-off-by: Leyi Rong > --- > config/common_base | 16 +- > drivers/net/Makefile | 2 +- > drivers/net/avf/avf.h | 216 -- > drivers/net/avf/base/avf_adminq_cmd.h | 2841 ----------------- > drivers/net/avf/base/avf_common.c | 1845 ----------- > drivers/net/avf/base/avf_hmc.h | 245 -- > drivers/net/avf/base/avf_prototype.h | 206 -- > drivers/net/avf/base/avf_register.h | 346 -- > drivers/net/avf/base/avf_status.h | 108 - > drivers/net/avf/base/avf_type.h | 2024 ------------ > drivers/net/{avf => iavf}/Makefile | 16 +- > drivers/net/{avf => iavf}/base/README | 8 +- > .../avf_adminq.c => iavf/base/iavf_adminq.c} | 582 ++-- > .../avf_adminq.h => iavf/base/iavf_adminq.h} | 116 +- > drivers/net/iavf/base/iavf_adminq_cmd.h | 2841 +++++++++++++++++ > .../avf_alloc.h => iavf/base/iavf_alloc.h} | 46 +- > drivers/net/iavf/base/iavf_common.c | 1845 +++++++++++ > .../avf_devids.h => iavf/base/iavf_devids.h} | 10 +- > drivers/net/iavf/base/iavf_hmc.h | 245 ++ > .../base/iavf_lan_hmc.h} | 132 +- > .../avf_osdep.h => iavf/base/iavf_osdep.h} | 82 +- > drivers/net/iavf/base/iavf_prototype.h | 206 ++ > drivers/net/iavf/base/iavf_register.h | 346 ++ > drivers/net/iavf/base/iavf_status.h | 108 + > drivers/net/iavf/base/iavf_type.h | 2024 ++++++++++++ > drivers/net/{avf => iavf}/base/meson.build | 6 +- > drivers/net/{avf => iavf}/base/virtchnl.h | 10 +- > drivers/net/iavf/iavf.h | 216 ++ > .../{avf/avf_ethdev.c => iavf/iavf_ethdev.c} | 730 ++--- > .../net/{avf/avf_log.h => iavf/iavf_log.h} | 20 +- > .../net/{avf/avf_rxtx.c => iavf/iavf_rxtx.c} | 592 ++-- > .../net/{avf/avf_rxtx.h => iavf/iavf_rxtx.h} | 162 +- > .../iavf_rxtx_vec_common.h} | 30 +- > .../iavf_rxtx_vec_sse.c} | 120 +- > .../{avf/avf_vchnl.c => iavf/iavf_vchnl.c} | 256 +- > drivers/net/{avf => iavf}/meson.build | 10 +- > .../rte_pmd_iavf_version.map} | 0 > drivers/net/meson.build | 2 +- > mk/rte.app.mk | 2 +- > 39 files changed, 9306 insertions(+), 9306 deletions(-) > delete mode 100644 drivers/net/avf/avf.h > delete mode 100644 drivers/net/avf/base/avf_adminq_cmd.h > delete mode 100644 drivers/net/avf/base/avf_common.c > delete mode 100644 drivers/net/avf/base/avf_hmc.h > delete mode 100644 drivers/net/avf/base/avf_prototype.h > delete mode 100644 drivers/net/avf/base/avf_register.h > delete mode 100644 drivers/net/avf/base/avf_status.h > delete mode 100644 drivers/net/avf/base/avf_type.h > rename drivers/net/{avf => iavf}/Makefile (73%) > rename drivers/net/{avf => iavf}/base/README (65%) > rename drivers/net/{avf/base/avf_adminq.c => iavf/base/iavf_adminq.c} (56%) > rename drivers/net/{avf/base/avf_adminq.h => iavf/base/iavf_adminq.h} (57%) > create mode 100644 drivers/net/iavf/base/iavf_adminq_cmd.h > rename drivers/net/{avf/base/avf_alloc.h => iavf/base/iavf_alloc.h} (66%) > create mode 100644 drivers/net/iavf/base/iavf_common.c > rename drivers/net/{avf/base/avf_devids.h => iavf/base/iavf_devids.h} (91%) > create mode 100644 drivers/net/iavf/base/iavf_hmc.h > rename drivers/net/{avf/base/avf_lan_hmc.h => iavf/base/iavf_lan_hmc.h} (59%) > rename drivers/net/{avf/base/avf_osdep.h => iavf/base/iavf_osdep.h} (60%) > create mode 100644 drivers/net/iavf/base/iavf_prototype.h > create mode 100644 drivers/net/iavf/base/iavf_register.h > create mode 100644 drivers/net/iavf/base/iavf_status.h > create mode 100644 drivers/net/iavf/base/iavf_type.h > rename drivers/net/{avf => iavf}/base/meson.build (83%) > rename drivers/net/{avf => iavf}/base/virtchnl.h (98%) > create mode 100644 drivers/net/iavf/iavf.h > rename drivers/net/{avf/avf_ethdev.c => iavf/iavf_ethdev.c} (57%) > rename drivers/net/{avf/avf_log.h => iavf/iavf_log.h} (72%) > rename drivers/net/{avf/avf_rxtx.c => iavf/iavf_rxtx.c} (73%) > rename drivers/net/{avf/avf_rxtx.h => iavf/iavf_rxtx.h} (58%) > rename drivers/net/{avf/avf_rxtx_vec_common.h => iavf/iavf_rxtx_vec_common.h} (87%) > rename drivers/net/{avf/avf_rxtx_vec_sse.c => iavf/iavf_rxtx_vec_sse.c} (85%) > rename drivers/net/{avf/avf_vchnl.c => iavf/iavf_vchnl.c} (74%) > rename drivers/net/{avf => iavf}/meson.build (63%) > rename drivers/net/{avf/rte_pmd_avf_version.map => iavf/rte_pmd_iavf_version.map} (100%) > Hi Leyi, Some of the files above look like removed and added new file, instead of renamed, like 'avf_type.h'. This makes this patch too big, and prevents the tractability. When you git log 'iavf_type.h' it shows a single commit that adds this file, if something is broken/forgotten while renaming 'avf' to 'iavf', no way to find it. Do you think how below works: 1- in first patch rename folders and files only, this will force you to update some includes in .c files and makefile/meson files, but I assume git can take this as renaming. 2- second patch update the context of the files, and search/replace each 'avf' with 'iavf'. This can let us to see the if and check easily if there is something wrong. Thanks, ferruh