From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0088.outbound.protection.outlook.com [104.47.42.88]) by dpdk.org (Postfix) with ESMTP id D6F5B2BA8 for ; Wed, 7 Dec 2016 10:55:32 +0100 (CET) Received: from BY2PR03CA079.namprd03.prod.outlook.com (10.141.249.52) by DM2PR0301MB0752.namprd03.prod.outlook.com (10.160.97.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.734.8; Wed, 7 Dec 2016 09:55:31 +0000 Received: from BY2FFO11FD013.protection.gbl (2a01:111:f400:7c0c::144) by BY2PR03CA079.outlook.office365.com (2a01:111:e400:2c5d::52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.9 via Frontend Transport; Wed, 7 Dec 2016 09:55:30 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD013.mail.protection.outlook.com (10.1.14.75) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.734.4 via Frontend Transport; Wed, 7 Dec 2016 09:55:30 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:; UpperCasedChecksum:; SizeAsReceived:998; Count:13 Received: from [127.0.0.1] ([10.232.133.65]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uB79tOPt009172; Wed, 7 Dec 2016 02:55:27 -0700 To: Thomas Monjalon , Ferruh Yigit References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1480875447-23680-19-git-send-email-hemant.agrawal@nxp.com> <2023a9a6-f342-8986-7ded-3703b3623a70@intel.com> <2956951.cEfl6HOu1U@xps13> CC: , , From: Hemant Agrawal Message-ID: <561c4838-4d8b-cdb4-f1eb-83b4092df5ab@nxp.com> Date: Wed, 7 Dec 2016 15:25:25 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2956951.cEfl6HOu1U@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IncomingHeaderCount: 13 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131255781307372186; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(336004)(339900001)(24454002)(377454003)(199003)(189002)(377424004)(81156014)(31686004)(189998001)(23746002)(105606002)(31696002)(5660300001)(65826007)(76176999)(50986999)(54356999)(33646002)(93886004)(86362001)(120886001)(47776003)(68736007)(305945005)(626004)(7246003)(7126002)(7846002)(8676002)(39850400001)(4326007)(83506001)(2906002)(229853002)(230700001)(39450400002)(356003)(77096006)(8666005)(64126003)(39410400001)(2950100002)(69596002)(39840400001)(39860400001)(39400400001)(38730400001)(39380400001)(5001770100001)(97736004)(50466002)(8936002)(104016004)(106466001)(36756003)(92566002)(65956001)(65806001)(81166006)(4001350100001)(85426001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0301MB0752; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD013; 1:xy+1DAmGare9t3MKVgB3VBADi9JcHdpLnVpjew2wida8nzzY5BWsM0/r2qAqC/ObyzybvwaGSJvgB/PdC8ATx6kIjvXkkmJ6ueQi+6ppnndkwgWaVZDJpSsoZyr82XMivVUKSIWr2kiNMeV2xwYU9Q7G/+VpAP7jO/V9qE7Uqu71zVZxUGb5cEaxIaKmkV5/sMzJ+I0FFy4+LxMOI0MkJnW6Is0GtLpw8VMxchjO4/v56hrFHZA8wREyX1YdvH9fJbZfu9erD6T3nVNFmma8WYHwZUbELvWLmlxrsjE3IzUDxkpKgoRn20mgDCfhaE+8OWuarkYtBWx5teTuUtaF6sC3lb0/BYgL1igIKEFzFXfDAxUXRYz9joX2cC4ofr5EqL9oFtgGpAi7k3Ig2JQxq7PYFp5PRkEt1/nydWkQGqe6JIWRPbNnp4iuO5DBJU2bOd8/88LwEw1H9041KmXXT3AoqiCL2kaZ3/X5qw5pKbM6p/uqSZrnWFCB+ECqxT8Ob9wgdjnmp4UrR+QhtSwc0ALkr8VriHc8ncjd6GelnNoBQn60MIad0IxI4IFSGvt9PQZKQrYGzeYtSfp0aXLvrmuA1w+BEdHc5av9L7J/zk7UeYFPkWACyzs5O3AL22zaNEa43wyfXKq0/v3YXO1smg== X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0752; 2:vTdKvdkUh7+ccjYGRp1EmPlzDs4X/tbaK6RsN/VGADWCulYLnyn1kpPuFkCRBFaQm7o4xy59/vEuC2cbFQ+1JQZX1bEf34YgxLUIPXnbGF/ceIvBp9nx1iETQC5ZicyyMu9wUnjbxVkbl8Huj75o/h1WOXRfknPWs/NGlSiUFco=; 3:BTsXA/qJNH3kfekUFY5VaO6irW9PmUDFHw2twd/SOjIoVGvRD4/x08VD7/bP/cizieYBTzwGCETi0Jl2fxTYuPPkEvhh3n7EgEb14+hV7BdIjchdCnTCqIhUrHA1+wXZ4kGNhUzb3j42BGE9FJuTlFCpJaoUeK1cOQnpk3tgeElZn8bGktCcuGLfvtEXl5fcWrGiJ5GhT4rECs+BGewXH8IELT/vGe831vsikqaRpgo9+yRdF3QsZUfP8mLG+nIwlbEx4Kkn3jo1AtXZaNNsjg== X-MS-Office365-Filtering-Correlation-Id: 147ec1db-bb57-4d16-7139-08d41e872dff X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DM2PR0301MB0752; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0752; 25:ZROZbyOJ8GhK9vzrI9Eb18NkpJd27nC1NzUmLKm6n4xL6DPefLFyu3JrJq/I1J4nLwJ6uACe5Q4bYE1ozwUfzpHv4oyQ6uBcmtbuvJLBn3UVHC8YO9/z/1SSnaHs3YATW5/FBOGhZ8IkXI7XUX1FzYcUrP4CAh3h6OozgBclzXHgE423bgOeQDqKIAU2mW01A7XCm6LHmPX08CQ34rdfLiUZfQGTdirYqDe1DqT67NU4oiQVpk7Z7t6ZY0qNkhLLviP9xYuDxBZDsITPQdIOAveN4uhuSXi5FsTVCZTSFBihb8t1GBvyZCJ1vW31EpjPrmxuWk2EWMyUMgUOEFV0jETqIGN7CrbI0oA+c0eDZIal6XrdSRqei0JNccE0+2RPULio/gFbmJsSTLFKCMJM8NjtJgcdFc+WAlOZ5bG5qlkifl+p+r1yDJF60i1LDE3hUKVnyBigy/3zZkEEEb9CCY9naJARwCL7IFUOFEmvOtA5r7zoJ/Utr5hTrw8kzIzh+UoCT/02WucYZdNyEcI6vmWxCc817bC1kDmv7tCnqBBnPctMVS8dizFjsF3KLG4TRFEkWtv7OYEu23Uc2h0N841fv10aApuD52fJeppwxy+/Sxx10VRZ7zQPS9sxe6PpeTNRMljvDB46pBZfs0Lz385nzkwtm4/wV6od20NVLziHuyemJxST13pGqfxfT3gM88RLCzBy2e1RiMz7Xf+Ibo2K8+gSRZ7ezD9h051fZnBITR2bGiV4j9JS1ccaoJk252xu+Ut4zEFr9avT29U6LThfSxQm9idymo/zqNiH3Bw= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0752; 31:LPSwNVjlNulsrOo0qUf391I+Y2U5mV+oBDf2HgfAGEEnzCyxnNG+2SPNNr3MXoY9b6I13YuG8zdAiDAxzeRcET4/5ECUJcUwdhNm4sN5fh41Hf1QxLo/YCmp3IomtBz6ap7Oen1zbdMdfzlG7scClcN3g1c/jStN/upNeccw/nlY4kJIy8Pro0wt8GQPhAskI4Rh6QubUV2pBAgeXMIx/vXkvA+bk5NBrwPts7L+l2lAfFDVvWucvQWi+nWG/fDP+HZXQhxmHk/wCMk8pV4Ar1pF5Loc4W5FUgnF6DbHNxw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13023025)(13024025)(13015025)(13017025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6096035)(20161123559025)(20161123556025)(20161123563025)(20161123561025)(20161123565025); SRVR:DM2PR0301MB0752; BCL:0; PCL:0; RULEID:(400006); SRVR:DM2PR0301MB0752; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0752; 4:SIdVTgR2YsYhRNG97QwIfWVZCrczrRsO6v+mSkg0eXMNoPkMCVUBsZxiZsbpQZxKJ0kLm5gN0EauG+6eQu2BXobRq8BWVjoOdSkL3CkiR0LGsIVdweIge2OPYNzjAl18UFf8J3TCeA3U9i5d1LeOvQemsN7FgGqh0xNagtaThcS90C0YTVeFnXeX5ReC2Z9Hh4dAIG6oRKmBdypVWc+MiLauCEuZY9pxNGUfEMTIS7MHEHEAyhrTO5u00F7llczeXPd7IA2GOL2I/KAOLNeB4SzKM1P6FYVjqFoxLNoBfzUtdyZX9t6B75+o5XQBBeCd7vJoZ6XN7rXXvfrhRcPUNbh6gPudycooaktpF/itjW0OvFw0hh/VA0L3qFXX3d7YYf2XLnBs5e/ZVJRXQ5lSU9sIy4ZfTDiSlli2uGP2ABriSoO4RjWodVZscD8eekK7ICnp66Zt9ypItpAl7VQQC3SoECacTjJQmEIBJ6o5xzEDgxDd2q7iMlvasBn+Fa0B1YNpBKrSiG33FP+MOS6Wf/toWViO49pYBbZPWOGMpt1ai1R8ifNjPQyCos6hCFXH65S+fgsSqfkQBwZ4N+nnvXTPdiWJTBUYFCwhwHud5zcuMtMJZzUsStoD7tiIsBpcM6H1WM1kEivTd+BLQ+EVyhApDTuMSLYJLG8NgnRcEXG7s93o7G1/CToI1f4v9xK2OWSfMzyXXZh0Li3MFX1kXCpysUui4nVo8J6Nrk4NOwCr/mZNr3++x/yb4oHWOJ0k X-Forefront-PRVS: 01494FA7F7 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM2PR0301MB0752; 23:oWdNlrbwO2illU4S12j7YjWE6OCM7PjyKdk?= =?Windows-1252?Q?94b6eKKsd04m9TZjNAZ7AzMxCmm1nlLC9lFXtlUKKUmrWFhhNFqvi6WB?= =?Windows-1252?Q?z1M2ReJyjKoaFu3i16iS/uVotUi+Go/aaltB34MPcxe1bbqqk4YV010A?= =?Windows-1252?Q?IMSq2Geg+Az1HGEdMREvWS18MC3ahlmECvoxEBHJF2ybJEO+dr22tyJV?= =?Windows-1252?Q?Gtad2AbX39y4AFoyKv8+HeAISwhtUWsRU5e/E5EODx8V4WsB41XmSLGN?= =?Windows-1252?Q?yiA6qActNhNXCRXB+O48+KrdMC53sNfV0GRNupp/UxL6jW4Lwx6Sf/G/?= =?Windows-1252?Q?v6ZaqkTOAEmL+C/R98byklbOkLQtyXJePq76nPvTVJTYhSZpnyOazLCL?= =?Windows-1252?Q?Oh78x8SAToIL4/ezWuMjf5RBVA+5boqbvej5x7bkyEfmNtwC/qqheSS9?= =?Windows-1252?Q?LYvT0KikQ94MwlEY4gDRxTp1mr6FXzcF1Gtu9SCwa0wZ6CPqvCZP/0in?= =?Windows-1252?Q?LtSCLOPlvxkqjnC6E62b2pdpljB2xw7ywgFvUUkcMw7U4SqCUcOBgUNW?= =?Windows-1252?Q?FwDw4Pe62OHsLxDzKH8WEsA8zEMY0xhHhzAZpd11Bve8Q+a03sGfcNgt?= =?Windows-1252?Q?8RkRsasBqrbiXgyAEXIWFRwKOqeMhGy9GaJAJmVCRKv6nL0qTlMIV9el?= =?Windows-1252?Q?cqQUpyYUpHuT/PVRLvBI8VQDCgcOO6dbYQXqVd6N3muPQYTYekpsIdyW?= =?Windows-1252?Q?4+oYaFu5JHiVlUijdaczAmSIF8zJVG1OcX2yUZVRiVRTK1PQEyBnrZ70?= =?Windows-1252?Q?eMgZMCTz7I2kIKXx6Aw3h2bNZDaFhA5ElpIywpETsaDjRk6dEj1G3t0i?= =?Windows-1252?Q?eGy++bpcpJTIb/5E2CB2ARHAXRcwgMSZqvK6bvwWAqKtwktdi4rFRoMW?= =?Windows-1252?Q?LFJWeFgYIfYoSHxVR1EtohjpYIe72IsLE3EASLepJcPFXOS58NsMeyB9?= =?Windows-1252?Q?1wxcTqE92seDVi71eSObdVMmVXJpsHXpR/uSeAA5EVZhyWLaNZniyyOB?= =?Windows-1252?Q?8hxiTMzn5h/5WF8Q6SZ5GtWJtVuCXtzyVS+mSeJLGl80AYNmIqM/eliL?= =?Windows-1252?Q?tyNDY6PHr8oacFp43IWfpr26nJHDo6uxJZUvtWeVD9k2f0nQHiFKzTSK?= =?Windows-1252?Q?IX/lAycUAIPLvp//lEFf8BOG1h/z8WeDxDbrNtAuNMoyXNo5GHIrUjpY?= =?Windows-1252?Q?1zVx4iRAclDqNgdlITBmw1idMRtov0Qa7FYgN7JrzXEbQhs9hjzTdiIa?= =?Windows-1252?Q?tyx7T+VyHO+Qr/nlrBVDhCaYa2GLlVTmJalyVWlCZ0PIQIrZ3mTxnIKL?= =?Windows-1252?Q?VqWBzzgkTmUxJXtGDFQgVbCI5/OsvzZa3uG1cOWcm1VQwegh3ID3dwsv?= =?Windows-1252?Q?VlWhnqkcktVm5vPlxNRxZdlgTzSeJba6fKQa1cSfh95qNXaWHOBQc59B?= =?Windows-1252?Q?ofRSulSVmiJlTWiZAtj625UbrJEJMWVRCK09A5iP9rd6IXxYAx2yDqK3?= =?Windows-1252?Q?cGPO2TeMtYTfx3rmgu+5KRgIPp3t1pNgnz2hUOlp8mxos3xnr6xzCqYY?= =?Windows-1252?Q?JqoZUYcrEzt9njKv8ouCqODN/2H2+kveerWWurt8L4lCHiS2T0JKWtwE?= =?Windows-1252?Q?ISMLgX3CaqGS2VytM6eHK5bJw3ElwdUCcMIk0LVZCzAia2rJgb33/FeT?= =?Windows-1252?Q?skSSAYSqmjNDKeMEh70Dxk2xJhCTTnC+J4DHljuc=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0752; 6:20hmvp7JtcXEgBgtZ0J92SVEV+4hpU3sASLOHZlmURtGV5yH3X/ihERWc3Mm7WHlXCm3TevxeXFo2QMT3QjBuF2Ar71X5fuI7HOEuIQKxm473lp4utQdbi25HgsuAECkJ8z+ngIH69hU7TJQIrbRqZNnzR7Ai6V5wN32YxtMmS41NBGtWEQhT+Yr+8AyKdceM04mxGuWOiVITWIJNYCT9cRlQ1ql1o9xA5cIOkFnStpWMChvFy3ckOxfHibFeZueko+q/PkM9VDby0n91NX//JtkbNkj7gZ5nvqDe4gi761B+x/vACRV5wlC0/ucbg3OuoDzzvlsmanbXRObGgJT0A==; 5:uyiY89R0zXE7GsLpkx1U+V9zy+350RVtjabgVY32TbDbrOYtbfLNFh1Iez9BQse7XtcGz5RupL6937OywXSpnBZTlW40p8YdhWKkhhVLAV9Q5o4vZRBywxxnD28Eu3+bvfMShJ/gUyHSi8L6Ea99A7act8OVk5sd5mto98RSP624FmOtKzBd/68nOzDUrmSi; 24:ECqkSptZ7qJ20LStmCsmyMj6DKKE/gbp9g1qaDwwPvpN8dFZVA3cAjnXsHGn5Tnudnp1k0FxcIvHxc8CffXgqeeZxN8yBRVSlaX19gfUegU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0752; 7:So0bKGhi6+xlLh+q1Yzy3xaTDHpHUUSTk2ajOQL61CxnK/hStShfhd5OlLrdeP/vHWiNpwmyQVyAJkUD+Mko4JsKGxs55isiN5gOdimbp8ZRyW+NrGDwmZYegZsrZ4rLpmQAvLGouJuQDgJ2r3w+ZZijbEMfwikQfiB8EaZIFl+tjqS4J1QvNK/LZ3e6cTivMjtT9x7Wiey8ph6tTfFEdHJqq2GZDEvFT6wIhCfQsQ6p8Wm2XMQiUZOxQH4BkuBBREgZ71gGqp5oCrE352fWlROcnLfzVyqEJJqjS7uFhOZgfcgCkVoMiFCzh1X3r7bcBM/+8x3/0J6cQbScqzGZCgKRBj6jWLaOih5UST5zFgQ= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2016 09:55:30.3472 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0752 Subject: Re: [dpdk-dev] [PATCH 18/32] net/dpaa2: introducing dpaa2 pmd driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 09:55:33 -0000 On 12/7/2016 2:38 AM, Thomas Monjalon wrote: > 2016-12-06 19:49, Ferruh Yigit: >> On 12/4/2016 6:17 PM, Hemant Agrawal wrote: >>> + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { >>> + eth_dev->data->dev_private = rte_zmalloc( >>> + "ethdev private structure", >>> + eth_drv->dev_private_size, >>> + RTE_CACHE_LINE_SIZE); >>> + if (eth_dev->data->dev_private == NULL) >>> + rte_panic("Cannot allocate memzone for private port" >>> + " data\n"); >> >> Should this error kill all app, or return an error for this PMD that is >> probed. > > It cannot be a question :) > rte_panic() inside libs or drivers is forbidden (and existing ones must > be removed). > I will change it to return an error.