From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8F22A0C4B; Mon, 8 Nov 2021 09:42:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E3F440DF7; Mon, 8 Nov 2021 09:42:28 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5D6E240040 for ; Mon, 8 Nov 2021 09:42:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636360945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RdivC/OYJX5T2t1CFN0lUuQjCKvuzvwvdvFGzb0VtKc=; b=eoNjMFemEoUnzfRzCN8WRhuczN848slqLRKJwQaTUilLT5XyOC7paEObgp6y9r+oNz0ruC yphrGjGLkK7v+SZ/UCBXeYkGxBp6sFVLGsjdA1UvkpuxYendYQhNCuSI2qyzLk9pkq98uN 7lpFDh4+yeVdxOYjC0Nr9Ew4fIlmIrQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-Z0HqjSh7M9WExW67TRYsBA-1; Mon, 08 Nov 2021 03:42:22 -0500 X-MC-Unique: Z0HqjSh7M9WExW67TRYsBA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6F492101AFA7; Mon, 8 Nov 2021 08:42:21 +0000 (UTC) Received: from [10.39.208.31] (unknown [10.39.208.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E45AF60936; Mon, 8 Nov 2021 08:42:19 +0000 (UTC) Message-ID: <561f1c88-91c0-c996-cce1-b05d4fbedc4a@redhat.com> Date: Mon, 8 Nov 2021 09:42:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: Jiayu Hu , dev@dpdk.org Cc: chenbo.xia@intel.com, cheng1.jiang@intel.com, xingguang.he@intel.com, stable@dpdk.org References: <1636021170-230805-1-git-send-email-jiayu.hu@intel.com> From: Maxime Coquelin In-Reply-To: <1636021170-230805-1-git-send-email-jiayu.hu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vhost: fix packed ring descriptor update in async enqueue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/4/21 11:19, Jiayu Hu wrote: > For the packet using multiple descriptors, the flag of first > descriptor cannot be updated until finishing updating the flag > of remaining descriptors. However, if the packet's descriptor > index is wrapped, the first descriptor's flag is updated earlier > than the others. The commit message is ambiguous IMHO, it is not clear whether it describes the bug or the fix. I understand it describes the problem, as the first descriptor flags always have to be updated last, but it please reword it to make it clear what iu the issue, and how this patch fixes it. > Fixes: 873e8dad6f49 ("vhost: support packed ring in async datapath") > Cc: stable@dpdk.org If you think it is worth backporting it to stable, please take care of preparing the backport as I suspect it will not apply cleanly. > Signed-off-by: Jiayu Hu > --- > lib/vhost/virtio_net.c | 122 ++++++++++++++++++----------------------- > 1 file changed, 54 insertions(+), 68 deletions(-) >