DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: getelson@nvidia.com
Cc: dev@dpdk.org, stable@dpdk.org, matan@nvidia.com,
	rasland@nvidia.com, Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [PATCH 2/2] doc: update MLX5 LRO limitation
Date: Mon, 21 Nov 2022 16:23:21 +0100	[thread overview]
Message-ID: <5620946.DvuYhMxLoT@thomas> (raw)
In-Reply-To: <20221117143901.27957-2-getelson@nvidia.com>

17/11/2022 15:39, Gregory Etelson:
> Maximal LRO message size must be multiply of 256.
> Otherwise, TCP payload may not fit into a single WQE.
> 
> Cc: stable@dpdk.org
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Why the doc update is not in the same patch as the code change?

> @@ -278,6 +278,9 @@ Limitations
>  - No Tx metadata go to the E-Switch steering domain for the Flow group 0.
>    The flows within group 0 and set metadata action are rejected by hardware.
>  
> +- The driver rounds down the ``max_lro_pkt_size`` value in the port
> +  configuration to a multiple of 256 due to HW limitation.
> +
>  .. note::
>  
>     MAC addresses not already present in the bridge table of the associated

If you would like to read the doc, I guess you'd prefer to find this info
in the section dedicated to LRO, not in a random place.






  reply	other threads:[~2022-11-21 15:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 14:39 [PATCH 1/2] net/mlx5: fix port private max_lro_msg_size Gregory Etelson
2022-11-17 14:39 ` [PATCH 2/2] doc: update MLX5 LRO limitation Gregory Etelson
2022-11-21 15:23   ` Thomas Monjalon [this message]
2022-11-22  5:17     ` Gregory Etelson
2022-11-22  8:25       ` Thomas Monjalon
2022-11-20 15:32 ` [PATCH 1/2] net/mlx5: fix port private max_lro_msg_size Raslan Darawsheh
2022-11-22  5:13 ` [PATCH v2 1/2] net/mlx5: fix port private max LRO msg size Gregory Etelson
2022-11-22  5:13   ` [PATCH v2 2/2] doc: update MLX5 LRO limitation Gregory Etelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5620946.DvuYhMxLoT@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=getelson@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).