From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA04C4240F; Wed, 18 Jan 2023 17:39:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53E2341101; Wed, 18 Jan 2023 17:39:20 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id D9844400D6; Wed, 18 Jan 2023 17:39:18 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E21E5320092F; Wed, 18 Jan 2023 11:39:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 18 Jan 2023 11:39:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674059956; x= 1674146356; bh=6puVbox9kyaJA5eRXB6tlSfpBFpcDCjRcNLMB/QZcWQ=; b=m DLzXJFrVPYfCCR0X+EFyF7xKqKYtj0/TELHhKxVO78WrqnpfdUhNeEE9+klLr7jC uIYg/apf22HxP14ZqaOhwWKjeVlh4HdKz6I9b5WXCQaIotdi+UwW7dy6czQ5P10J wzGcxDIyzZKHCBG11bMgf28PUJ+eTX2gm7s2PDUxjC91yp4/x94pPku0VQDiiwSX H+LANbnzMjFib1QZ+zMPlfTRgO1xFMSwlxdXNkD5AcqfV6LxsUhD1jDFUomc6G9n XfyuHrQAtnIdOfC+6dyh3sR1SI8G/rC3zQbRaLEN7iyWrmYb68/wBtNbrQtuNWmB ZlUVeixcu52h/RDq9SU7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674059956; x= 1674146356; bh=6puVbox9kyaJA5eRXB6tlSfpBFpcDCjRcNLMB/QZcWQ=; b=Q 92QlCYw2eQ8+d5TvPPHDlIG8CoQFXoC3Bwrt+CQPx1LcI3hmYf4oHYZLKjvNQ+3r 49EjQOskKfDQozOTBI+kA/1m+M9f2kDy+LnZd/L3VbQW5FCQPr3NCa+eFd/wliod S0611KRlEVgdxKhXj8BNDLr+GqM09p4Vw4prbf65haf6QnRGM/gmz2SBuAnRDYwO ETKMIRWbI1FSjSL8+G6SlNNWgWjbvYVeGMfXKoVphNPEr/of5FsxC+0zI+A8IlLf dhZcmnR5OJdVS8ZsoAA+G4n6vlEbWw3hvxYYWuXnuwbKmDFywb4RwIucOzFBy+BW /oYbAXNUy+GnUM/qyiiFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtkedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Jan 2023 11:39:14 -0500 (EST) From: Thomas Monjalon To: Anoob Joseph Cc: Akhil Goyal , Jerin Jacob , Konstantin Ananyev , dev@dpdk.org, Hemant Agrawal , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Kiran Kumar K , Volodymyr Fialko , Olivier Matz , techboard@dpdk.org Subject: Re: [PATCH 0/5] lib: add pdcp protocol Date: Wed, 18 Jan 2023 17:39:13 +0100 Message-ID: <5622577.tWeucmBOSa@thomas> In-Reply-To: <20221222092522.1628-1-anoobj@marvell.com> References: <20221027052140.155-1-anoobj@marvell.com> <20221222092522.1628-1-anoobj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org For such new library, I think we need to vote in techboard to accept it. That's a process we had in recent years to keep the project scope in control. 22/12/2022 10:25, Anoob Joseph: > Add Packet Data Convergence Protocol (PDCP) processing library. > > The library is similar to lib_ipsec which provides IPsec processing > capabilities in DPDK. > > PDCP would involve roughly the following options, > 1. Transfer of user plane data > 2. Transfer of control plane data > 3. Header compression > 4. Uplink data compression > 5. Ciphering and integrity protection > > PDCP library provides following control path APIs that is used to > configure various PDCP entities, > 1. rte_pdcp_entity_establish() > 2. rte_pdcp_entity_suspend() > 3. rte_pdcp_entity_release() > > PDCP process is split into 2 parts. One before crypto processing > (rte_pdcp_pkt_pre_process()) and one after crypto processing > (rte_pdcp_pkt_post_process()). Since cryptodev dequeue can return crypto > operations belonging to multiple entities, rte_pdcp_pkt_crypto_group() > is added to help grouping crypto operations belonging to same entity. > > Similar to lib IPsec, lib PDCP would allow application to use same API > sequence while leveraging protocol offload features enabled by rte_security > library. Lib PDCP would internally change the handles registered for > *pre_process* and *post_process* based on features enabled in the entity. > > Lib PDCP would create the required sessions on the device provided in entity to > minimize the application requirements. Also, the crypto_op allocation and free > would also be done internally by lib PDCP to allow the library to create > crypto ops as required for the input packets. For example, when control PDUs are > received, no cryptodev enqueue-dequeue is expected for the same and lib PDCP > is expected to handle it differently.