From: Thomas Monjalon <thomas@monjalon.net>
To: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: dev@dpdk.org, Jerin Jacob <jerinjacobk@gmail.com>,
Jerin Jacob <jerinj@marvell.com>, Gavin Hu <gavin.hu@arm.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] lib/bpf: fix clang build warnings for aarch64
Date: Thu, 21 Nov 2019 00:32:34 +0100 [thread overview]
Message-ID: <5623373.E9auGC82IA@xps> (raw)
In-Reply-To: <CALBAE1MKZrdrLMo35vck=cU3RhwNOhHiubk90adZ2_8kFaAh+A@mail.gmail.com>
15/11/2019 08:14, Jerin Jacob:
> On Fri, Nov 15, 2019 at 12:18 PM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
> >
> > Clang has different prototype for __builtin___clear_cache(). It requires
> > 'char *' parameters while gcc requires 'void *'.
> >
> > Clang version 8.0 was used.
> > Warning messages during build:
> > ../lib/librte_bpf/bpf_jit_arm64.c:1438:26: warning: incompatible pointer
> > types passing 'uint32_t *' (aka 'unsigned int *') to parameter of type
> > 'char *' [-Wincompatible-pointer-types]
> > __builtin___clear_cache(ctx.ins, ctx.ins + ctx.idx);
> > ^~~~~~~
> > ../lib/librte_bpf/bpf_jit_arm64.c:1438:35: warning: incompatible pointer
> > types passing 'uint32_t *' (aka 'unsigned int *') to parameter of type
> > 'char *' [-Wincompatible-pointer-types]
> > __builtin___clear_cache(ctx.ins, ctx.ins + ctx.idx);
> > ^~~~~~~~~~~~~~~~~
> >
> > Fixes: f3e516772464 ("bpf/arm: add prologue and epilogue")
> > Cc: jerinj@marvell.com
> >
> > Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks
prev parent reply other threads:[~2019-11-20 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 3:18 [dpdk-dev] [PATCH] " Ruifeng Wang
2019-11-15 3:45 ` Jerin Jacob
2019-11-15 6:47 ` [dpdk-dev] [PATCH v2] " Ruifeng Wang
2019-11-15 7:14 ` Jerin Jacob
2019-11-20 23:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5623373.E9auGC82IA@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).