From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <declan.doherty@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2597F941A
 for <dev@dpdk.org>; Wed, 21 Oct 2015 13:08:53 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 21 Oct 2015 04:08:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,711,1437462000"; d="scan'208";a="668709678"
Received: from unknown (HELO dwdohert-dpdk-fedora-20.ir.intel.com)
 ([163.33.213.96])
 by orsmga003.jf.intel.com with ESMTP; 21 Oct 2015 04:08:50 -0700
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1443826867-21004-1-git-send-email-declan.doherty@intel.com>
 <1443826867-21004-2-git-send-email-declan.doherty@intel.com>
 <4348530.B8pRXVWZvF@xps13>
From: Declan Doherty <declan.doherty@intel.com>
Message-ID: <56277404.7050803@intel.com>
Date: Wed, 21 Oct 2015 12:16:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <4348530.B8pRXVWZvF@xps13>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/6] cryptodev: Initial DPDK Crypto APIs and
 device framework release
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Oct 2015 11:08:53 -0000

On 21/10/15 10:24, Thomas Monjalon wrote:
> Hi Declan,
>
> 2015-10-03 00:01, Declan Doherty:
>> Co-authored-by: Des O Dea <des.j.o.dea@intel.com>
>> Co-authored-by: John Griffin <john.griffin@intel.com>
>> Co-authored-by: Fiona Trahe <fiona.trahe@intel.com>
>
> Common practice is to use Signed-off-by below for co-authors.

Cool, I didn't know that, I will change in the V2.

>
>> This patch contains the initial proposed APIs and device framework for
>> integrating crypto packet processing into DPDK.
>>
>> features include:
>>   - Crypto device configuration / management APIs
>>   - Definitions of supported cipher algorithms and operations.
>>   - Definitions of supported hash/authentication algorithms and
>>     operations.
>>   - Crypto session management APIs
>>   - Crypto operation data structures and APIs allocation of crypto
>>     operation structure used to specify the crypto operations to
>>     be performed  on a particular mbuf.
>>   - Extension of mbuf to contain crypto operation data pointer and
>>     extra flags.
>>   - Burst enqueue / dequeue APIs for processing of crypto operations.
>
> It would be easier to review if features were split in separate patches.
> You don't need to have a fine grain but maybe 1 patch for basic management
> then 1 for the session management, 1 for the algos and another 1 for the stats.

I'll take a look and see how feasible it would be to split the patches 
that way.

>
> Other comment: you've added some API which are not implemented (hotplug, restore).
> Why not declare them later when they will be implemented?
>

I'll remove these

> The QuickAssist doc is not needed if the code is not submitted.
>

There is a QuickAssist PMD included in the patch set, see patch 2/6

> Volunteer for a sub-tree?
> Thanks.
>