From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D6A36374E
 for <dev@dpdk.org>; Tue, 27 Oct 2015 09:48:53 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 27 Oct 2015 01:48:43 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,204,1444719600"; d="scan'208";a="588763922"
Received: from aaltazin-mobl2.amr.corp.intel.com (HELO [10.252.27.32])
 ([10.252.27.32])
 by FMSMGA003.fm.intel.com with ESMTP; 27 Oct 2015 01:48:42 -0700
Message-ID: <562F3A69.1040306@intel.com>
Date: Tue, 27 Oct 2015 08:48:41 +0000
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: "Tahhan, Maryam" <maryam.tahhan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1443603881-4700-1-git-send-email-remy.horton@intel.com>
 <1443603881-4700-3-git-send-email-remy.horton@intel.com>
 <1A27633A6DA49C4A92FCD5D4312DBF536A5D9327@IRSMSX109.ger.corp.intel.com>
In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536A5D9327@IRSMSX109.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 2/3] l2fwd: keep alive sample application
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Oct 2015 08:48:54 -0000



On 23/10/2015 15:23, Tahhan, Maryam wrote:

>>   # binary name
>> -APP = l2fwd
>> +APP = l2fwd-keepalive
> Hi Remy,
> Looks great overall, just a couple of comments
> For backward compatibility the rename could be a nightmare? What do you think?

True. Undecided whether to change the Makefile(s) so that both keepalive 
and non-keepalive l2fwd are built, or to simply clone all of l2fwd..


>> +		 * Die randomly within 7 secs for demo purposes if
>> +		 * keepalive enables
>> +		 */
>
> Typo: If keepalive is enabled

Fixed.. :)