From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 797875682 for ; Thu, 29 Oct 2015 00:24:12 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 28 Oct 2015 16:24:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,212,1444719600"; d="scan'208";a="837938420" Received: from achristi-mobl5.ger.corp.intel.com (HELO [10.252.6.253]) ([10.252.6.253]) by fmsmga002.fm.intel.com with ESMTP; 28 Oct 2015 16:24:00 -0700 From: Sergio Gonzalez Monroy To: Shesha Sreenivasamurthy References: <1446069865-18733-1-git-send-email-shesha@cisco.com> Message-ID: <5631590F.9040606@intel.com> Date: Wed, 28 Oct 2015 23:23:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446069865-18733-1-git-send-email-shesha@cisco.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v8] mem: command line option to delete hugepage backing files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 23:24:12 -0000 On 28/10/2015 22:04, Shesha Sreenivasamurthy wrote: > When an application using huge-pages crash or exists, the hugetlbfs > backing files are not cleaned up. This is a patch to clean those files. > There are multi-process DPDK applications that may be benefited by those > backing files. Therefore, I have made that configurable so that the > application that does not need those backing files can remove them, thus > not changing the current default behavior. The application itself can > clean it up, however the rationale behind DPDK cleaning it up is, DPDK > created it and therefore, it is better it unlinks it. > > Signed-off-by: Shesha Sreenivasamurthy > Acked-by: Sergio Gonzalez Monroy > --- v3: - Fix typo in comments v2: - Update function X return value > lib/librte_eal/common/eal_common_options.c | 12 +++++++++++ > lib/librte_eal/common/eal_internal_cfg.h | 1 + > lib/librte_eal/common/eal_options.h | 2 ++ > lib/librte_eal/linuxapp/eal/eal_memory.c | 32 ++++++++++++++++++++++++++++++ > 4 files changed, 47 insertions(+) > > Patch looks good! Just a couple of things for the next time ;) You might be aware of them, but it doesn't hurt to remind them: - When sending new version, use --in-reply-to to the last version of the patch sent, it's easier to have all patches on the same thread (if your email client supports it) - Also when sending new versions it's useful to add what has changed from the previous to the new version. (add such info after the three dashes as shown above) Cheers, Sergio