From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 11B2EE5D for ; Mon, 11 Dec 2017 13:36:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 04:36:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="185940038" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.117]) ([10.237.220.117]) by fmsmga006.fm.intel.com with ESMTP; 11 Dec 2017 04:36:14 -0800 To: dev@dpdk.org References: <20171115154545.8936-1-xuemingl@mellanox.com> <20171115154545.8936-3-xuemingl@mellanox.com> From: "Burakov, Anatoly" Message-ID: <56330f7d-7744-39a5-2315-4b0e9f71470d@intel.com> Date: Mon, 11 Dec 2017 12:36:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171115154545.8936-3-xuemingl@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: support command echo in CLI batch loading X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 12:36:17 -0000 On 15-Nov-17 3:45 PM, Xueming Li wrote: > Use first bit of verbose_level to enable CLI echo of batch loading. > > Signed-off-by: Xueming Li > --- > app/test-pmd/cmdline.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index f5a483ad7..b40fe1ac7 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -15853,7 +15853,8 @@ cmdline_read_from_file(const char *filename) > { > struct cmdline *cl; > > - cl = cmdline_file_new(main_ctx, "testpmd> ", filename); > + cl = cmdline_file_new(main_ctx, "testpmd> ", filename, > + verbose_level & 0x8000); > if (cl == NULL) { > printf("Failed to create file based cmdline context: %s\n", > filename); > I don't see verbose_level being used in testpmd other than checking if it's zero, so maybe just verbose level >= 2 instead of highest significant bit? -- Thanks, Anatoly