From: Thomas Monjalon <thomas@monjalon.net>
To: Luca Boccassi <bluca@debian.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Eelco Chaudron <echaudro@redhat.com>,
dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Ian Stokes <ian.stokes@intel.com>,
Andrzej Ostruszka <amo@semihalf.com>
Subject: Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal
Date: Thu, 30 Jan 2020 16:55:40 +0100 [thread overview]
Message-ID: <5634584.alqRGMn8q6@xps> (raw)
In-Reply-To: <71b93a9bbebf1f047f24d3f455eab1bf2712dcf4.camel@debian.org>
30/01/2020 15:21, Luca Boccassi:
> On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote:
> > 30/01/2020 13:57, Luca Boccassi:
> > > On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote:
> > > > Hi,
> > > >
> > > > I disagree with the need of this patch.
> > > > The symbol was experimental, meaning we can change it.
> > > > Removing experimental tag is not an ABI break.
> > >
> > > Hi,
> > >
> > > This symbol change was requested for backport in 19.11.x, and
> > > experimental or not I'm not too keen on backward incompatible
> > > changes
> > > to the public interface in an _LTS point release_. The compromise
> > > was
> > > to see if we could support both symbols version, which makes the
> > > change
> > > backward compatible.
> > >
> > > If you prefer not to have this patch in mainline I'm also fine in
> > > taking it just for the LTS. I agree with you that it is not
> > > required
> > > for mainline releases (although nicer for me if it's a backport
> > > rather
> > > than a new change).
> >
> > I would like to avoid opening the door for maintaining the
> > experimental ABI
> > in the mainline. Please take it directly in the LTS.
> >
> > The next question is to know whether we really want to have such
> > patch in LTS.
> > Anyway, 19.11.0 has this symbol as experimental.
> > How adding a non-experimental version of the function in 19.11.1 will
> > change
> > the ABI status of the whole 19.11 branch?
>
> The problem is not adding the new symbol, but removing the experimental
> one. Changing the version of the symbol was requested by OVS for
> inclusion in 19.11.
Yes, sorry, this is what I meant.
Given 19.11.0 already has the symbol as experimental,
and that applications like OVS had to accept it as experimental,
why removing experimental tag in 19.11.1?
next prev parent reply other threads:[~2020-01-30 15:55 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 12:29 [dpdk-dev] [RFC] " Ferruh Yigit
2020-01-29 14:46 ` Bruce Richardson
2020-01-29 14:57 ` Andrzej Ostruszka
2020-01-29 16:25 ` Ferruh Yigit
2020-01-29 16:30 ` Andrzej Ostruszka
2020-01-29 16:40 ` Ferruh Yigit
2020-01-29 16:43 ` [dpdk-dev] [RFC v2] " Ferruh Yigit
2020-01-29 17:49 ` Andrzej Ostruszka
2020-01-30 12:33 ` Thomas Monjalon
2020-01-30 12:57 ` Luca Boccassi
2020-01-30 14:17 ` Thomas Monjalon
2020-01-30 14:21 ` Luca Boccassi
2020-01-30 15:55 ` Thomas Monjalon [this message]
2020-01-30 16:04 ` Luca Boccassi
2020-01-30 16:15 ` Eelco Chaudron
2020-01-30 20:20 ` Thomas Monjalon
2020-02-03 11:10 ` Eelco Chaudron
2020-01-31 9:25 ` Ferruh Yigit
2020-05-13 12:11 ` [dpdk-dev] [PATCH] meter: provide experimental alias of API for old apps Ferruh Yigit
2020-05-13 16:30 ` Thomas Monjalon
2020-05-13 17:37 ` Ferruh Yigit
2020-05-13 18:05 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2020-05-14 8:44 ` Ray Kinsella
2020-05-14 11:53 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-05-14 11:52 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2020-05-14 15:10 ` Ray Kinsella
2020-05-14 15:32 ` David Marchand
2020-05-14 15:56 ` Ray Kinsella
2020-05-14 16:07 ` Ferruh Yigit
2020-05-14 16:30 ` David Marchand
2020-05-14 16:11 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2020-05-15 13:31 ` Thomas Monjalon
2020-05-15 14:41 ` Ray Kinsella
2020-05-15 15:03 ` Ray Kinsella
2020-05-15 14:36 ` [dpdk-dev] [PATCH v5] abi: " Ray Kinsella
2020-05-15 15:01 ` [dpdk-dev] [PATCH v6] " Ray Kinsella
2020-05-16 11:53 ` Neil Horman
2020-05-18 17:18 ` Thomas Monjalon
2020-05-18 17:34 ` Ferruh Yigit
2020-05-18 17:51 ` Thomas Monjalon
2020-05-18 18:32 ` Ferruh Yigit
2020-05-19 14:13 ` Ray Kinsella
2020-05-19 14:14 ` Ray Kinsella
2020-05-17 19:52 ` [dpdk-dev] [PATCH v4] meter: " Dumitrescu, Cristian
2020-05-18 6:29 ` Ray Kinsella
2020-05-18 9:22 ` Thomas Monjalon
2020-05-18 9:30 ` Ray Kinsella
2020-05-18 10:46 ` Thomas Monjalon
2020-05-18 11:18 ` Dumitrescu, Cristian
2020-05-18 11:49 ` Ray Kinsella
2020-05-18 11:48 ` Ray Kinsella
2020-05-18 12:13 ` Thomas Monjalon
2020-05-18 13:06 ` Ray Kinsella
2020-05-18 18:30 ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2020-05-19 12:16 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2020-05-19 13:26 ` Dumitrescu, Cristian
2020-05-19 14:24 ` Thomas Monjalon
2020-05-19 14:22 ` Ray Kinsella
2020-02-02 18:53 ` [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal Neil Horman
2020-02-03 12:53 ` Ferruh Yigit
2020-02-04 12:02 ` Neil Horman
2020-02-05 10:04 ` Luca Boccassi
2020-02-05 11:32 ` Neil Horman
2020-02-13 17:40 ` Ray Kinsella
2020-02-14 2:40 ` Neil Horman
2020-02-14 11:36 ` Bruce Richardson
2020-02-14 20:48 ` Neil Horman
2020-02-14 21:52 ` Bruce Richardson
2020-02-15 13:43 ` Neil Horman
2020-02-17 14:23 ` Ray Kinsella
2020-02-17 15:37 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5634584.alqRGMn8q6@xps \
--to=thomas@monjalon.net \
--cc=amo@semihalf.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=ferruh.yigit@intel.com \
--cc=ian.stokes@intel.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).