From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3E549378E for ; Sun, 1 Nov 2015 10:01:01 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 712ACA302C; Sun, 1 Nov 2015 09:01:00 +0000 (UTC) Received: from [10.36.5.70] (vpn1-5-70.ams2.redhat.com [10.36.5.70]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA190w6B025387; Sun, 1 Nov 2015 04:00:58 -0500 To: Thomas Monjalon , "Michael S. Tsirkin" References: <1444907319-26348-1-git-send-email-marcel@redhat.com> <20151016135230.GF9980@bricha3-MOBL3> <20151018095438-mutt-send-email-mst@redhat.com> <2413695.XHLO16SCPC@xps13> From: Marcel Apfelbaum Message-ID: <5635D4C8.4030407@redhat.com> Date: Sun, 1 Nov 2015 11:00:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <2413695.XHLO16SCPC@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2015 09:01:01 -0000 On 10/30/2015 07:48 PM, Thomas Monjalon wrote: > 2015-10-18 10:04, Michael S. Tsirkin: >> On Fri, Oct 16, 2015 at 02:52:30PM +0100, Bruce Richardson wrote: >>> On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: >>>> On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: >>>>> Make vhost-user virtio 1.0 compatible by adding it to the >>>>> supported features and keeping the header length >>>>> the same as for mergeable RX buffers. >>>>> >>>>> Signed-off-by: Marcel Apfelbaum >>>> >>>> Looks good to me >>>> >>>> Acked-by: Michael S. Tsirkin >>>> >>>> Just one question: dpdk is only supported on little-endian >>>> platforms at the moment, right? >>> >>> A recent release added in support for PPC (patches supplied by IBM). For >>> example, see: >>> http://dpdk.org/browse/dpdk/commit/?id=704ba3770032c5a901719d3837845581d5a56b58 >>> >>> /Bruce >> >> This will require more work then as 1.0 is a different >> endian-ness from 0.9. It's up to you guys to decide >> whether correct BE support is now a requirement for all >> new dpdk code. Let us know. > Hi, > I'm not sure to understand. > Yes DPDK must work on big endian platforms. > Does this patch prevent from using virtio 0.9 with big endian? No, if it worked until now, will continue to work. (And the other way around) However, if virtio 1.0 is supported by both QEMU and vhost-user, virtio 1.0 has different endianess requirements than prev virtio, Michael can better elaborate more. > Does it work with old QEMU not supporting virtio 1.0? Yes, it does. virtio 1.0 will be enabled only if the feature is supported by both QEMU and vhost-user backend, otherwise it will work as before. Thanks, Marcel >