From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A4E0D8E8C for ; Tue, 3 Nov 2015 12:43:34 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id EE93B19F27D; Tue, 3 Nov 2015 11:43:33 +0000 (UTC) Received: from dhcp195.koti.laiskiainen.org (vpn1-5-179.ams2.redhat.com [10.36.5.179]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA3BhWZU018459; Tue, 3 Nov 2015 06:43:33 -0500 To: dev@dpdk.org, Eric Kinzie , Ferruh Yigit References: <20151102102023.GA29052@sivlogin002.ir.intel.com> <1446477827-11541-1-git-send-email-ferruh.yigit@intel.com> <56385CDD.2030909@redhat.com> <20151103092033.GA16414@sivlogin002.ir.intel.com> <56388F46.7040405@redhat.com> <20151103113346.GA14881@sivlogin002.ir.intel.com> From: Panu Matilainen Message-ID: <56389DE4.2020002@redhat.com> Date: Tue, 3 Nov 2015 13:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151103113346.GA14881@sivlogin002.ir.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Subject: Re: [dpdk-dev] [PATCH v2] mk: fix ABI versioning compile error for combined shared library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 11:43:34 -0000 On 11/03/2015 01:33 PM, Ferruh Yigit wrote: > On Tue, Nov 03, 2015 at 12:41:10PM +0200, Panu Matilainen wrote: >> On 11/03/2015 11:20 AM, Ferruh Yigit wrote: >>> On Tue, Nov 03, 2015 at 09:06:05AM +0200, Panu Matilainen wrote: >>>> On 11/02/2015 05:23 PM, Ferruh Yigit wrote: >>>>> Fixes following error: >>>>> LD libdpdk.so >>>>> /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found >>>>> for symbol @DPDK_x.y >>>>> >>>>> Defines version symbols in a fixed path libdpdk.map file and this >>>>> value hardcoded into makefile >>>> >>>> Hold on. What problem is this supposed to be fixing? >>> This patch is to fix combined library compilation error when ABI versining used. >>> Currently if ABI version macros used (VERSION_SYMBOL), we are not able to compile combined shared library. >>> >>>> If its for the bonding thing (as it'd appear from the threading), NAK. >>> Nothing directly related to the bonding, just issue observed in this thread. >> >> Okay, understood, it was just not clear from the description. Since there >> are no users of VERSION_SYMBOL etc macros this error has not come up until >> now. >> >>> >>>> The symbol versioning in >>>> that patch is confused needs to be fixed there instead of inventing strange >>>> workarounds elsewhere. >>>> >>> This is not intented to be a workaround but a fix, unless you have a better idea. >> >> The problem is, it undoes the other benefit of symbol versioning: hiding the >> internal symbols. So in my eyes its more of a hack or a workaround than a >> fix. >> >> I'd much much rather see this as a solution: >> http://dpdk.org/dev/patchwork/patch/4262/ >> > What I observed from this, how/why combined library should be generated is under question, from that perspective I agree this patch is a hack. > If current method is used, this patch just fixes compile error, also patch is not related to versioning in combined library, which is still broken. The linker script eliminates the whole versioning problem because it just makes the actual individual libraries *appear* as a single entity during build-time, whereas the current approach physically lumps it all together. - Panu -