From: "Hunt, David" <david.hunt@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>,
Gavin Hu <gavin.hu@arm.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
nd <nd@arm.com>, Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix distributor unit test
Date: Fri, 25 Oct 2019 09:20:59 +0100 [thread overview]
Message-ID: <563ac490-809f-1e8c-6f07-3ddfb7e72687@intel.com> (raw)
In-Reply-To: <CAJFAV8zLokcr4imRN_G42WGu9A_S+yq4=nOBnTT39=E=jEEnwA@mail.gmail.com>
On 25/10/2019 09:18, David Marchand wrote:
> On Fri, Oct 25, 2019 at 10:11 AM Hunt, David <david.hunt@intel.com> wrote:
>>
>> On 24/10/2019 20:31, David Marchand wrote:
>>> On Tue, Oct 15, 2019 at 11:29 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
>>>> Bug 342 reported distributor_autotest execution suspension
>>>> on aarch64 platform.
>>>> Issue was due to lack of synchronization among threads. Distributor
>>>> thread and worker thread may get deadlocked.
>>>> Fixed synchronization issue by adding barriers.
>>>>
>>>> Another issue identified was in test case. Non-atomic operation on
>>>> stat value could cause value reset not been observed by worker thread
>>>> and mess counters. The issue was fixed by using atomic operations.
>>>>
>>>> ---
>>>> v3:
>>>> Added comments for using of C11 acquire/release semantics. (Honnappa)
> The comments are also something to maintain, so checking the v3 made
> sense to me.
I agree, and the comments look good to me.
>
>>>> v2:
>>>> Fixed intermittent packet count incorrect failure. (Aaron, David)
>>>> Fixed Clang build on 32bit systems.
>>>> Additional patch to fix non-atomic operation in unit test.
>>> David,
>>>
>>> Can you review this series?
>>> Thanks.
>>>
>> Hi David,
>>
>> I had tested this previously, including performance comparisons
>> against original version on x86, and saw no performance degradation, so
>> I Acked it. I can re-ack on the latest version now.
> If you think this is fine as is, I will go and apply with your ack.
Sure, thanks.
Regards,
Dave.
next prev parent reply other threads:[~2019-10-25 8:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:55 [dpdk-dev] [PATCH] lib/distributor: fix deadlock issue for aarch64 Ruifeng Wang
2019-10-08 12:53 ` Hunt, David
2019-10-08 17:05 ` Aaron Conole
2019-10-08 19:46 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-10-08 20:08 ` Aaron Conole
2019-10-09 5:52 ` Ruifeng Wang (Arm Technology China)
2019-10-17 11:42 ` [dpdk-dev] [EXT] " Harman Kalra
2019-10-17 13:48 ` Ruifeng Wang (Arm Technology China)
2019-10-12 2:43 ` [dpdk-dev] [PATCH v2 0/2] fix distributor unit test Ruifeng Wang
2019-10-12 2:43 ` [dpdk-dev] [PATCH v2 1/2] lib/distributor: fix deadlock issue for aarch64 Ruifeng Wang
2019-10-13 2:31 ` Honnappa Nagarahalli
2019-10-14 10:00 ` Ruifeng Wang (Arm Technology China)
2019-10-12 2:43 ` [dpdk-dev] [PATCH v2 2/2] test/distributor: fix false unit test failure Ruifeng Wang
2019-10-15 9:28 ` [dpdk-dev] [PATCH v3 0/2] fix distributor unit test Ruifeng Wang
2019-10-15 9:28 ` [dpdk-dev] [PATCH v3 1/2] lib/distributor: fix deadlock issue for aarch64 Ruifeng Wang
2019-10-25 8:13 ` Hunt, David
2019-10-15 9:28 ` [dpdk-dev] [PATCH v3 2/2] test/distributor: fix false unit test failure Ruifeng Wang
2019-10-25 8:13 ` Hunt, David
2019-10-24 19:31 ` [dpdk-dev] [PATCH v3 0/2] fix distributor unit test David Marchand
2019-10-25 8:11 ` Hunt, David
2019-10-25 8:18 ` David Marchand
2019-10-25 8:20 ` Hunt, David [this message]
2019-10-25 8:33 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563ac490-809f-1e8c-6f07-3ddfb7e72687@intel.com \
--to=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=hkalra@marvell.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).