From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mukawa@igel.co.jp>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 8226B591F
 for <dev@dpdk.org>; Tue, 10 Nov 2015 04:14:23 +0100 (CET)
Received: by pasz6 with SMTP id z6so226315714pas.2
 for <dev@dpdk.org>; Mon, 09 Nov 2015 19:14:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=igel_co_jp.20150623.gappssmtp.com; s=20150623;
 h=subject:to:references:cc:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-type:content-transfer-encoding;
 bh=Vj+/+Ps905LBoYAemSuElq3u57P52X0i9jtpd1rJSt0=;
 b=A/+oNt8MzEB45FCZqJj+suD9NpoCE9j5hpleiTO27J7L+3b2+1GMRnVN2uOfyYe20T
 4Te3/7hTIBSYYAwzNGo6MMz8MSbLMCI8G0wEalsvxJRoAfd1w4zUPI6X8+JzdOXZl5XE
 XD8kUdiyXJ9J/WPMP7fVwVcXozPUQAc+tD5BbAL6bbUTCrowQbqX5ZloZ+r3dLlzvmGd
 OpnlB50ApdXVRrV2B+XJUVZuJzW4IslxEz4H0/KK+CoyRDe0brGANNO7o7BkRbmMafWJ
 nD/3mGqmj6D7JRucdkNzcmuQ8cf+hCiIFKSgSBawJOer5DydYiKDE1nZ2rh70zZduYjG
 EIrA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:subject:to:references:cc:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-type
 :content-transfer-encoding;
 bh=Vj+/+Ps905LBoYAemSuElq3u57P52X0i9jtpd1rJSt0=;
 b=VEjDLEHDAVrc2iXn7Uwi93hJ3e4PUScrHwkl6HXQ3ptFFmj+xsByqGTAnS5wKDyPqJ
 pdYCp43bHLrVX11u+93WgRKY6SEnSd0Q0kd0FuX7N2ze5YBCSyG2soeHNz/2aL4TzPZG
 Twg1+INrbtmeXXgzzAyZ0+RelITSh4IraIdyK29a6HS4FrXWZigvpc+DJGj300uLAPNk
 8n7ywzugDkAYopi6lKdToC50fK6My2tjLNf/P0iz8FaTArGzsigfMbqOHfnBqm2jPNmD
 yHslHk80dT4bPKAcT87ibsx5WfK660EdKhS4PhvoYeDzfFcHGuTu1NhdyOUBpYONNdh0
 mi+Q==
X-Gm-Message-State: ALoCoQnSCzPuw0+Vi5nLnlK2qn/Z5bN/q5jpEQ51kkQXLUrIjrBO7tJXYtZ6tf03LBez3FDKvXqC
X-Received: by 10.66.235.40 with SMTP id uj8mr1949856pac.151.1447125262874;
 Mon, 09 Nov 2015 19:14:22 -0800 (PST)
Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132])
 by smtp.googlemail.com with ESMTPSA id tp6sm882204pbc.81.2015.11.09.19.14.21
 (version=TLSv1/SSLv3 cipher=OTHER);
 Mon, 09 Nov 2015 19:14:22 -0800 (PST)
To: Stephen Hemminger <stephen@networkplumber.org>
References: <1446436737-25606-2-git-send-email-mukawa@igel.co.jp>
 <1447046221-20811-1-git-send-email-mukawa@igel.co.jp>
 <1447046221-20811-3-git-send-email-mukawa@igel.co.jp>
 <20151109142205.4040ec07@xeon-e3>
From: Tetsuya Mukawa <mukawa@igel.co.jp>
X-Enigmail-Draft-Status: N1110
Message-ID: <5641610B.30107@igel.co.jp>
Date: Tue, 10 Nov 2015 12:14:19 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151109142205.4040ec07@xeon-e3>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com
Subject: Re: [dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Nov 2015 03:14:23 -0000

On 2015/11/10 7:22, Stephen Hemminger wrote:
> On Mon,  9 Nov 2015 14:17:01 +0900
> Tetsuya Mukawa <mukawa@igel.co.jp> wrote:
>
>> +	rte_atomic32_set(&r->while_queuing, 1);
>> +
>> +	if (unlikely(rte_atomic32_read(&r->allow_queuing) == 0))
>> +		goto out;
> You special 2 variable custom locking here is buggy.
> If you hit second atomic test, you will leave while_queuing set.

Hi Stephen,

Thanks for reviewing.
I clear while_queuing like below.

+out:
+	rte_atomic32_set(&r->while_queuing, 0);
+
+	return nb_rx;
+}

Thanks,
tetsuya