From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5F33E5592 for ; Thu, 18 Aug 2016 09:52:13 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5BE904E4C8; Thu, 18 Aug 2016 07:52:12 +0000 (UTC) Received: from [10.36.4.244] (vpn1-4-244.ams2.redhat.com [10.36.4.244]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7I7qAAl003921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Aug 2016 03:52:11 -0400 To: Jianfeng Tan , dev@dpdk.org References: <1471499173-11749-1-git-send-email-jianfeng.tan@intel.com> Cc: yuanhan.liu@linux.intel.com From: Maxime Coquelin Message-ID: <56458495-5ee1-ff9c-c2d0-819b120cfcbc@redhat.com> Date: Thu, 18 Aug 2016 09:52:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471499173-11749-1-git-send-email-jianfeng.tan@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 18 Aug 2016 07:52:12 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] examples/vhost: remove VLAN strip option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2016 07:52:13 -0000 On 08/18/2016 07:46 AM, Jianfeng Tan wrote: > When VMDQ is enabled, different NICs have different behaviors for > disabling VLAN strip. In detail, i40e only enables/disables it of > PF's main vsi; fm10k cannot disable VLAN strip, etc. We now remove > this option, --vlan-strip, to reduce any confusion. And now, VLAN > strip will be enabled and cannot be disabled. > > Reported-by: Qian Xu > Signed-off-by: Jianfeng Tan > --- > doc/guides/sample_app_ug/vhost.rst | 11 ++++------- > examples/vhost/main.c | 26 +------------------------- > 2 files changed, 5 insertions(+), 32 deletions(-) Minor comment below. Other than that: Reviewed-by: Maxime Coquelin > diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst > index 2b7defc..a204f78 100644 > --- a/doc/guides/sample_app_ug/vhost.rst > +++ b/doc/guides/sample_app_ug/vhost.rst > @@ -496,13 +496,10 @@ due to the large and complex code, it's better to redesign it than fixing > it to make it work again. Hence, zero copy may be added back later. > > **VLAN strip.** > -The VLAN strip option enable/disable the VLAN strip on host, if disabled, the guest will receive the packets with VLAN tag. > -It is enabled by default. > - > -.. code-block:: console > - > - ./vhost-switch -c f -n 4 --socket-mem 1024 --huge-dir /mnt/huge \ > - -- --vlan-strip [0, 1] > +VLAN strip option is removed, because different NICs have different behaviors > +when disabling VLAN strip. Such feature, which heavily depends on hardware, > +should be removed from this example to deduce confusion. Now, VLAN strip is I'm not a native English speaker, but I would use "reduce" instead of "deduce" here. I might be wrong, so feel free to keep as-is if appropriate. Thanks, Maxime