From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <declan.doherty@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 3D84895C0
 for <dev@dpdk.org>; Fri, 13 Nov 2015 17:26:47 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 13 Nov 2015 08:26:28 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,288,1444719600"; d="scan'208";a="684727273"
Received: from dwdohert-dpdk-fedora-20.ir.intel.com (HELO
 dwdohert-dpdk-fedora-23.ir.intel.com) ([163.33.213.71])
 by orsmga003.jf.intel.com with ESMTP; 13 Nov 2015 08:26:27 -0800
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1447101259-18972-1-git-send-email-declan.doherty@intel.com>
 <1447176763-19303-1-git-send-email-declan.doherty@intel.com>
 <1447176763-19303-8-git-send-email-declan.doherty@intel.com>
 <1834242.iLgMQtWqy4@xps13>
From: Declan Doherty <declan.doherty@intel.com>
Message-ID: <56460EFF.8040806@intel.com>
Date: Fri, 13 Nov 2015 16:25:35 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1834242.iLgMQtWqy4@xps13>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 07/10] qat_crypto_pmd: Addition of a new
 QAT DPDK PMD.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2015 16:26:47 -0000

On 13/11/15 16:00, Thomas Monjalon wrote:
> 2015-11-10 17:32, Declan Doherty:
>> --- a/lib/librte_mbuf_offload/rte_mbuf_offload.h
>> +++ b/lib/librte_mbuf_offload/rte_mbuf_offload.h
>> @@ -123,17 +123,10 @@ rte_pktmbuf_offload_get(struct rte_mbuf *m, enum rte_mbuf_ol_op_type type)
>>   {
>>          struct rte_mbuf_offload *ol = m->offload_ops;
>>
>> -       if (m->offload_ops != NULL && m->offload_ops->type == type)
>> -               return ol;
>> -
>> -       ol = m->offload_ops;
>> -       while (ol != NULL) {
>> +       for (ol = m->offload_ops; ol != NULL; ol = ol->next)
>>                  if (ol->type == type)
>>                          return ol;
>>
>> -               ol = ol->next;
>> -       }
>> -
>>          return ol;
>>   }
>
> Strange: why changing the code of the previous patch?
>

I squashed this tidy up into the wrong patch. I'll fix in v7