From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A92DC5A53 for ; Wed, 18 Nov 2015 11:21:18 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 18 Nov 2015 02:21:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,312,1444719600"; d="scan'208";a="822984850" Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.230.15]) ([163.33.230.15]) by orsmga001.jf.intel.com with ESMTP; 18 Nov 2015 02:21:10 -0800 Message-ID: <564C5115.4070703@intel.com> Date: Wed, 18 Nov 2015 10:21:09 +0000 From: Remy Horton Organization: Intel Shannon Limited User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1446723178-14876-1-git-send-email-remy.horton@intel.com> <1446723178-14876-2-git-send-email-remy.horton@intel.com> <20151111082801.3eedaf21@xeon-e3> In-Reply-To: <20151111082801.3eedaf21@xeon-e3> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 1/3] rte: add keep alive functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2015 10:21:19 -0000 On 11/11/2015 16:28, Stephen Hemminger wrote: > Also Linux has more robust mechanism in the watchdog timers, why not use that? Keepalive was made with tight intra-process reporting intervals of 5-10ms in mind, whereas Linux watchdog appears to be an inter-process system that operates with granularity of seconds. > Could you use RTE_PER_LCORE some how? Possibly, although not sure what it gains.. >> + struct rte_keepalive *keepcfg = (struct rte_keepalive *)ptr_data; > Cast of void * is unnecessary in C. Old habbits die hard.. :) v+1 on way. ..Remy