From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 8C6168D96 for ; Thu, 19 Nov 2015 02:20:52 +0100 (CET) Received: by padhx2 with SMTP id hx2so62387885pad.1 for ; Wed, 18 Nov 2015 17:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=XUNknjJS84OPvMGAhEsefcSIvvTB2eITdKKiqVufG4s=; b=SQ66tgVYNTBHqt6yghY7r/dQzskTQe29wo2jCGbQHO6S9Gxg2YT2pEnCIl5kuuU9gO ZeNfTFQMhHUR3a8jvpya6r1Gcr1j9R6RmKxA1HQGs7O8Je8j5aUGdiTYaj86FI9KKh5s AcWlXfkkzfWH+MyeXrjXEBytdrod9HAHGYR5RM0ZH7WvacMrLdAaj5FuoQL50QvLUTIj C7tcrTc8zUhVRj+WPjdfIWpbZj8XYtrH1TTmgEGw3WU7Lz4/8ssYPn12f5B5qzAOsOuI WwHx5fOB50VOahHZFPGUuo748KGxfeGBO8W9e/hAAPuH/ma0V1pY0oxMdGIpRfrOtIK9 KESQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=XUNknjJS84OPvMGAhEsefcSIvvTB2eITdKKiqVufG4s=; b=M0q2VxHY2DjvhLAbh3Ghp+eWAld1e08q9Y3hgqJ13PSE7hXEL1iBS2s5+ZYdebg8wO YY+8eNbtzfeOoGhUOt7se8lLw21DARXGwf7XDYxbp4+Y///P8KBh+NCRvS3+kmkcm5mm W7kx2Q16O9tdPVb/goP5r9Yt5vuWVllnSEUtBHYNGzUZdjgJJc3O4rjm9lNq2kcShko+ /vzxvC9KkRRAXxPdsoJtUCY2h9gGenlHE3A1ncYH0phgTLr7vCrGofW3tuD5wNfSDUjD SFqZcqsT4qFplztFP0HwrcKqJ4/D7Mh6MbKJVMrazK3YFuR1zKzahSkg8uBugmVZoqX2 HvPw== X-Gm-Message-State: ALoCoQnelcm//jm1st7IjsqkkZzUYEL7Eq/j/foaINFQ9pimfHhQ69O1ls93ott8FyvpC0iHluLx X-Received: by 10.66.100.166 with SMTP id ez6mr6525863pab.49.1447896051919; Wed, 18 Nov 2015 17:20:51 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id kh9sm6602522pad.11.2015.11.18.17.20.50 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Nov 2015 17:20:51 -0800 (PST) To: Yuanhan Liu References: <1447046221-20811-3-git-send-email-mukawa@igel.co.jp> <1447392031-24970-1-git-send-email-mukawa@igel.co.jp> <20151113053215.GN2326@yliu-dev.sh.intel.com> <56458828.7070009@igel.co.jp> <20151117132636.GU2326@yliu-dev.sh.intel.com> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <564D23F0.1090100@igel.co.jp> Date: Thu, 19 Nov 2015 10:20:48 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151117132636.GU2326@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com Subject: Re: [dpdk-dev] [PATCH v4 0/2] Add VHOST PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 01:20:53 -0000 On 2015/11/17 22:26, Yuanhan Liu wrote: > On Fri, Nov 13, 2015 at 03:50:16PM +0900, Tetsuya Mukawa wrote: >> On 2015/11/13 14:32, Yuanhan Liu wrote: >>> On Fri, Nov 13, 2015 at 02:20:29PM +0900, Tetsuya Mukawa wrote: >>>> The patch introduces a new PMD. This PMD is implemented as thin wrapper >>>> of librte_vhost. >>>> >>>> * Known issue. >>>> We may see issues while handling RESET_OWNER message. >>>> These handlings are done in vhost library, so not a part of vhost PMD. >>>> So far, we are waiting for QEMU fixing. >>> Fix patches have already been applied. Please help test :) >>> >>> --yliu >> Hi Yuanhan, >> >> It seems there might be an another issue related with "vq->callfd" in >> vhost library. >> We may miss something to handle the value correctly. >> >> Anyway, here are steps. >> 1. Apply vhost PMD patch. >> (I guess you don't need it to reproduce the issue, but to reproduce it, >> using the PMD may be easy) >> 2. Start testpmd on host with vhost-user PMD. >> 3. Start QEMU with virtio-net device. >> 4. Login QEMU. >> 5. Bind the virtio-net device to igb_uio. >> 6. Start testpmd in QEMU. >> 7. Quit testmd in QEMU. >> 8. Start testpmd again in QEMU. >> >> It seems when last command is executed, testpmd on host doesn't receive >> SET_VRING_CALL message from QEMU. >> Because of this, testpmd on host assumes virtio-net device is not ready. >> (I made sure virtio_is_ready() was failed on host). >> >> According to QEMU source code, SET_VRING_KICK will be called when >> virtqueue starts, but SET_VRING_CALL will be called when virtqueue is >> initialized. >> Not sure exactly, might be "vq->call" will be valid while connection is >> established? > Yes, it would be valid as far as we don't reset it from another > set_vring_call. So, we should not reset it on reset_device(). > > --yliu Hi Yuanhan, Thanks for checking. I will submit the patch for this today. Tetsuya >> Also I've found a workaround. >> Please execute after step7. >> >> 8. Bind the virtio-net device to virtio-pci kernel driver. >> 9. Bind the virtio-net device to igb_uio. >> 10. Start testpmd in QEMU. >> >> When step8 is executed, connection will be re-established, and testpmd >> on host will be able to receive SET_VRING_CALL. >> Then testpmd on host can start. >> >> Thanks, >> Tetsuya