* [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
@ 2017-07-26 11:27 Akhil Goyal
2017-07-27 8:52 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 5+ messages in thread
From: Akhil Goyal @ 2017-07-26 11:27 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, hemant.agrawal, Akhil Goyal
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
drivers/crypto/dpaa2_sec/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/dpaa2_sec/Makefile b/drivers/crypto/dpaa2_sec/Makefile
index c2a02ed..ae15c99 100644
--- a/drivers/crypto/dpaa2_sec/Makefile
+++ b/drivers/crypto/dpaa2_sec/Makefile
@@ -46,9 +46,11 @@ CFLAGS += $(WERROR_FLAGS)
endif
CFLAGS += -D _GNU_SOURCE
+ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
ifeq ($(shell test $(GCC_VERSION) -gt 70 && echo 1), 1)
CFLAGS += -Wno-implicit-fallthrough
endif
+endif
CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/
CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/mc
--
2.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
2017-07-26 11:27 [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain Akhil Goyal
@ 2017-07-27 8:52 ` De Lara Guarch, Pablo
2017-07-27 11:42 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-27 8:52 UTC (permalink / raw)
To: Akhil Goyal, dev; +Cc: hemant.agrawal
HI Akhil,
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, July 26, 2017 12:28 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
I think you need to include a fixes line here, and CC stable, as this is a fix.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
2017-07-27 8:52 ` De Lara Guarch, Pablo
@ 2017-07-27 11:42 ` Akhil Goyal
2017-07-27 12:48 ` De Lara Guarch, Pablo
2017-07-27 14:33 ` De Lara Guarch, Pablo
0 siblings, 2 replies; 5+ messages in thread
From: Akhil Goyal @ 2017-07-27 11:42 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: hemant.agrawal
On 7/27/2017 2:22 PM, De Lara Guarch, Pablo wrote:
> HI Akhil,
>
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Wednesday, July 26, 2017 12:28 PM
>> To: dev@dpdk.org
>> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
>> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>
>> Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
>>
>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> I think you need to include a fixes line here, and CC stable, as this is a fix.
>
This is not valid for 17.05 stable release. This is recently added in
below commit. Should I resend this patch with commit message updated?
ed5ed6b344f2 ("crypto/dpaa2_sec: remove GCC 7.1 compilation error")
Thanks,
Akhil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
2017-07-27 11:42 ` Akhil Goyal
@ 2017-07-27 12:48 ` De Lara Guarch, Pablo
2017-07-27 14:33 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-27 12:48 UTC (permalink / raw)
To: Akhil Goyal, dev; +Cc: hemant.agrawal
Hi,
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, July 27, 2017 12:43 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: hemant.agrawal@nxp.com
> Subject: Re: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
>
> On 7/27/2017 2:22 PM, De Lara Guarch, Pablo wrote:
> > HI Akhil,
> >
> >> -----Original Message-----
> >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> >> Sent: Wednesday, July 26, 2017 12:28 PM
> >> To: dev@dpdk.org
> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> >> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>
> >> Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
> >>
> >> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > I think you need to include a fixes line here, and CC stable, as this is a fix.
> >
>
> This is not valid for 17.05 stable release. This is recently added in below
> commit. Should I resend this patch with commit message updated?
>
> ed5ed6b344f2 ("crypto/dpaa2_sec: remove GCC 7.1 compilation error")
Oh, you are right. Well, I can add the line for you.
Thanks,
Pablo
>
> Thanks,
> Akhil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
2017-07-27 11:42 ` Akhil Goyal
2017-07-27 12:48 ` De Lara Guarch, Pablo
@ 2017-07-27 14:33 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-27 14:33 UTC (permalink / raw)
To: Akhil Goyal, dev; +Cc: hemant.agrawal
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, July 27, 2017 12:43 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: hemant.agrawal@nxp.com
> Subject: Re: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
>
> On 7/27/2017 2:22 PM, De Lara Guarch, Pablo wrote:
> > HI Akhil,
> >
> >> -----Original Message-----
> >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> >> Sent: Wednesday, July 26, 2017 12:28 PM
> >> To: dev@dpdk.org
> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> >> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>
> >> Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
> >>
> >> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > I think you need to include a fixes line here, and CC stable, as this is a fix.
> >
>
> This is not valid for 17.05 stable release. This is recently added in below
> commit. Should I resend this patch with commit message updated?
>
> ed5ed6b344f2 ("crypto/dpaa2_sec: remove GCC 7.1 compilation error")
>
> Thanks,
> Akhil
Added fixes line [Fixes: 6a95466d78de ("crypto/dpaa2_sec: fix build with gcc 7.1")].
Remember to use the commit ID of the patch that was actually merged.
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-27 14:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26 11:27 [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain Akhil Goyal
2017-07-27 8:52 ` De Lara Guarch, Pablo
2017-07-27 11:42 ` Akhil Goyal
2017-07-27 12:48 ` De Lara Guarch, Pablo
2017-07-27 14:33 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).