From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 2492D2906 for ; Thu, 7 Apr 2016 19:34:43 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id u206so96733978wme.1 for ; Thu, 07 Apr 2016 10:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=P5jVgwhJjb8hn6Kx3lwPnMqVxBocozXPkCk2FM9t1Y8=; b=pWLzTvTW7jcZWYBd4AQTDR/Sq/0vjF1ONFAXHb+3MOv+XC/GWF2Boq8aIQJNQCTcRZ vF1ods/+IE0IDFCv2nGL20AFE787jhGptbaU+7jrop4p9Jmenzz2xWBIMmQYG6VAt8A9 WC4pUH0VskQwx8eIBvicagy2pCQgZjlXDb2moDr5T/+jzoryIBoAi13wQteLkDhH2XVT ubgaPjO/Fc3V+j0stzxQJ7/l3CiSz8F0o2E2JvWq9VfG3ydKKRCvMnZRCuO84HJewSQO w5/ZEf4lqzEUGNH2M8eDrvrCKy8QG0jWkhgX+9YnZYthRrzbeORw92Ruw2ngmcPUTT0Z pWaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=P5jVgwhJjb8hn6Kx3lwPnMqVxBocozXPkCk2FM9t1Y8=; b=Xekb3R1+5mEFiBtcDia4EX8fMSMEDHkNFcfNCg1nTL1gMpT7Pj3BTxS0kB3gHvmeSh 81MULA5BM3xh5Ndk9DP53Vv+DlgGqFa1vfR/GGBLTKb/Ui4UwDV8Vh3IhttxTbpKa++w sxZ1bCzxro+BnUOqiK8KMGc/J0+6MjA5A9+uOEN/YiHVdKxYF2jPk4radavdK5fqXABC ySwHJhH2WBJ/jHdchBhOWWi94kP97vRGcxlWON2Dh1Rz5oDLEwHHsmpw7fkk43lDoekT ZguJXK9DpEwfU5wTcsOxlgMzg0FNppHeEnjgnNPtoXxJu0uvpDSjg2chgBSV3SQQ6Xdk uOMA== X-Gm-Message-State: AD7BkJKjkRQ8gpxShyw8pyxweKUcXPGF5Mg8YY1S38xbi1UbSav5/y6hDkUPseQvHGZclX6z X-Received: by 10.28.72.10 with SMTP id v10mr30343899wma.89.1460050482932; Thu, 07 Apr 2016 10:34:42 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id b1sm9534807wjy.0.2016.04.07.10.34.41 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 07 Apr 2016 10:34:42 -0700 (PDT) From: Thomas Monjalon To: John Guzik , Yong Wang Cc: dev@dpdk.org Date: Thu, 07 Apr 2016 19:34:41 +0200 Message-ID: <5660045.mydYX4O3xK@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] vmxnet3 driver - vlan offload is on end descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2016 17:34:43 -0000 2016-04-07 17:11, John Guzik: > With the new jumbo frame patch a latent bug has appeared to have been uncovered: the VLAN offload is on the last rx descriptor, when rcd->eop is true, not the first rx descriptor, when rcd->sop is true and rcd->eop could be false. > Most likely the reason this has not been seen before is that for non-jumbo frames rcd->eop has always been true when rcd->sop is true as well. Thanks for reporting. Please Yong, could you confirm? John, 2 tags are needed to be applied: Fixes: commit-origin-of-the-bug Signed-off-by: Please check http://dpdk.org/dev#send for more details. Thanks