From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 06AC4568A
 for <dev@dpdk.org>; Thu,  3 Dec 2015 14:26:33 +0100 (CET)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 by mx1.redhat.com (Postfix) with ESMTPS id 7C236C0B0207;
 Thu,  3 Dec 2015 13:26:32 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-4-137.ams2.redhat.com
 [10.36.4.137])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 tB3DQU1E020794; Thu, 3 Dec 2015 08:26:31 -0500
To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>
 <1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <56604306.4080203@redhat.com>
Date: Thu, 3 Dec 2015 15:26:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
Subject: Re: [dpdk-dev] [PATCH v2 00/12] standard make install
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 13:26:33 -0000

On 12/03/2015 07:01 AM, Thomas Monjalon wrote:
> Following the recent discussions, this is a proposal to have a standard
> installation process while keeping compatibility with most of the old
> behaviours.
>
> v2 changes:
> - fix default build dir
> - RTE_TARGET subdir in $(sdkdir).
> - better kerneldir defaults
> - fix dpdk_nic_bind symlink
> - always install doc if generated
> - doc
> - pkg/dpdk.spec
>

Except for the minor nit about examples location (one could bikeshed on 
things like these forever), seems fine to me and quick-n-dirty 
conversion of my own spec didn't reveal any nasty surprises.

It also appears more comprehensive and integrated with other workflows 
than the competing patches so FWIW, you have my ACK :)

	- Panu -