From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 95DEC37A6
 for <dev@dpdk.org>; Tue,  8 Dec 2015 17:28:26 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga103.jf.intel.com with ESMTP; 08 Dec 2015 08:28:07 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,400,1444719600"; d="scan'208";a="856530131"
Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.68])
 ([10.237.220.68])
 by fmsmga001.fm.intel.com with ESMTP; 08 Dec 2015 08:28:06 -0800
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>
References: <c9b9eaf80bdadfa4282467eafd290a5c090456fc.1449575210.git.pmatilai@redhat.com>
Message-ID: <56670516.7050701@intel.com>
Date: Tue, 8 Dec 2015 16:28:06 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <c9b9eaf80bdadfa4282467eafd290a5c090456fc.1449575210.git.pmatilai@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix external shared library
 dependencies of libraries
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2015 16:28:27 -0000

On 08/12/2015 11:47, Panu Matilainen wrote:
> Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a etc, but
> for libraries. Clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion
> while at it.
>
> Requiring applications to know about library internal details like
> dependencies to external helper libraries is a limitation of
> static linkage, shared libraries should always know their own
> dependencies for sane operation.
>
> Linking with the combined library (whether shared or not) still
> requires knowing the internal dependencies, and intra-dpdk
> dependencies are also not currently recorded.
>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> ---
>
> v2:
> - clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion while at it
>
>
Hi Panu,

Patch itself looks good but there is a small side effect on BSD that results
in app/test not linking because of missing -lm.
Linuxapp links with -lm by default (EXECENV_LDLIBS), but BSD does not.

Should we just add -lm to EXECENV_LDLIBS for BSD too instead of
adding it on each app/example that uses librte_sched ?

Sergio